doc: fix typos and grammar in BUILDING.md & onboarding.md #61267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Author
|
@cjihrig can you please take a look at this PR ? |
Contributor
|
I think you forgot to push a commit as you fixed some typo/grammar but not the those you described. |
Author
|
@Xstoudi Thanks for the review! I've pushed the changes, can you please re-review and approve if possible thanks |
gireeshpunathil
approved these changes
Jan 4, 2026
MikeMcC399
reviewed
Jan 4, 2026
MikeMcC399
reviewed
Jan 4, 2026
MikeMcC399
reviewed
Jan 4, 2026
Hardanish-Singh
changed the title
MikeMcC399
reviewed
Jan 4, 2026
Contributor
There was a problem hiding this comment.
I would suggest splitting changes to BUILDING.md and onboarding.md into separate PRs as they are different subject areas.
You can wait to see what regular Collaborator reviewers say first though. I am only a Contributor here and I got involved because you commented on my PR #61261
aduh95
approved these changes
Jan 4, 2026
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I agree that splitting in two PRs would be nice, though not a blocker
cjihrig
approved these changes
Jan 4, 2026
lpinca
approved these changes
Jan 4, 2026
RafaelGSS
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few grammatical errors and missing words in
BUILDING.mdto improve readability: