Skip to content

doc: fix typos and grammar in BUILDING.md & onboarding.md #61267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 4 commits into from
Jan 6, 2026
Merged

doc: fix typos and grammar in BUILDING.md & onboarding.md #61267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e37f5a
doc: fix typos and grammar in BUILDING.md
Hardanish-Singh Jan 3, 2026
d46d744
doc: fix typos and grammar in BUILDING.md
Hardanish-Singh Jan 4, 2026
32d4e00
doc: fix typos and grammar in BUILDING.md
Hardanish-Singh Jan 4, 2026
d4ec22f
doc: fix typos and grammar in BUILDING.md & onboarding.md
Hardanish-Singh Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ on Linux, you can try [Docker](https://www.docker.com/products/docker-desktop/)
(using an image like `gengjiawen/node-build:2020-02-14`).

The `--debug` is not necessary and will slow down build and testing, but it can
show clear stacktrace if ASan hits an issue.
show a clear stack trace if ASan hits an issue.

```bash
./configure --debug --enable-asan && make -j4
Expand Down Expand Up @@ -713,8 +713,8 @@ the number of parallel build tasks (`-j<n>`).

#### Tips

You may need disable vcpkg integration if you got link error about symbol
redefine related to zlib.lib(zlib1.dll), even you never install it by hand,
You may need to disable vcpkg integration if you encounter a link error about symbol
redefinition related to zlib.lib(zlib1.dll), even if you never installed it by hand,
as vcpkg is part of CLion and Visual Studio now.

```powershell
Expand Down Expand Up @@ -889,7 +889,7 @@ cp c:\ccache\ccache.exe c:\ccache\cl.exe
```

With newer version of Visual Studio, it may need the copy to be `clang-cl.exe`
instead. If the output of `vcbuild.bat` suggestion missing `clang-cl.exe`, copy
instead. If the output of `vcbuild.bat` suggests missing `clang-cl.exe`, copy
it differently:

```powershell
Expand Down Expand Up @@ -1052,7 +1052,7 @@ configure option:
## Building Node.js with Temporal support

Node.js supports the [Temporal](https://github.com/tc39/proposal-temporal) APIs, when
linking statically or dynamically with a version [temporal\_rs](https://github.com/boa-dev/temporal).
linking statically or dynamically with a version of [temporal\_rs](https://github.com/boa-dev/temporal).

To build Node.js with Temporal support, a Rust toolchain is required:

Expand Down
4 changes: 2 additions & 2 deletions onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ needs to be pointed out separately during the onboarding.
* If you are interested in helping to fix coverity reports consider requesting
access to the projects coverity project as outlined in [static-analysis][].
* If you are interested in helping out with CI reliability, check out the
[reliability respository][] and [guide on how to deal with CI flakes][].
[reliability repository][] and [guide on how to deal with CI flakes][].

[Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
[Labels]: doc/contributing/collaborator-guide.md#labels
Expand All @@ -299,7 +299,7 @@ needs to be pointed out separately during the onboarding.
[`node-test-pull-request`]: https://ci.nodejs.org/job/node-test-pull-request/
[guide on how to deal with CI flakes]: https://github.com/nodejs/test?tab=readme-ov-file#protocols-in-improving-ci-reliability
[participants' expenses]: https://github.com/openjs-foundation/cross-project-council/blob/main/community-fund/COMMUNITY_FUND_POLICY.md#community-fund-rules
[reliability respository]: https://github.com/nodejs/reliability
[reliability repository]: https://github.com/nodejs/reliability
[set up the credentials]: https://github.com/nodejs/node-core-utils#setting-up-github-credentials
[static-analysis]: doc/contributing/static-analysis.md
[two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/
Expand Down
Loading