Skip to content

Conversation

Muhammad-Altabba
Copy link

@Muhammad-Altabba Muhammad-Altabba commented Apr 10, 2025

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:
As part of: nucypher/taco-web#635, implement tests that generate shared secrets encrypt/decrypt values to check the TS implementation agains them.
Also README.md file has been updated.

Issues fixed/closed:

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

description: String,
shared_secret: Vec<u8>,
plaintext: Option<String>,
fixed_nonce: Option<Vec<u8>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be annotated with #[serde(with = "serde_bytes::as_hex")] similarly to bytestring fields in the main code, this way the test vectors will look a little tidier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, just FYI, the umbral_pre::serde_bytes (that I wrote back in the day) has since been extracted into https://docs.rs/serde-encoded-bytes

@Muhammad-Altabba Muhammad-Altabba force-pushed the generate-shared-secret-test-vector branch from 1efbb84 to 3853f75 Compare April 12, 2025 13:37
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 23.66%. Comparing base (5b531a4) to head (270cb58).

Files with missing lines Patch % Lines
nucypher-core/src/dkg.rs 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   23.42%   23.66%   +0.23%     
==========================================
  Files          18       18              
  Lines        3475     3436      -39     
==========================================
- Hits          814      813       -1     
+ Misses       2661     2623      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Muhammad-Altabba Muhammad-Altabba force-pushed the generate-shared-secret-test-vector branch from e9b905f to 2b73a71 Compare April 14, 2025 21:47
+ in addtion to some refactorying
+ update README file
@Muhammad-Altabba Muhammad-Altabba force-pushed the generate-shared-secret-test-vector branch from 2b73a71 to 9771e18 Compare April 14, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants