[Fix]: Properly handle base64 image compression for iOS #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling
Compressor.compress()with a base64 input on iOS, the ImageCompressor module handles it as a URL, and therefore prependsfile:///to it before initializing a SwiftDataobject, which causes the compression process to fail.This PR modifies the ImageCompressor class to call
getAbsoluteImagePathonly if the compressor'sinputoption is set to anything other thanbase64. If the input isbase64, it will be handled by automatic/manual handlers as-is and will be properly mapped toImageUI.The rest of the compression process that was expecting the input to always be a URL has been modified to handle the input polymorphism.
Changelog
Issues
Fixes #299