Skip to content

[Fix]: Properly handle base64 image compression for iOS #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fix]: Properly handle base64 image compression for iOS #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad500cd
[fix]: Properly handle base64 image compression
ajacquierbret Oct 2, 2025
b7469ee
[fix]: Change fileSize typing to Int instead of Double
ajacquierbret Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 63 additions & 37 deletions ios/Image/ImageCompressor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,25 +101,33 @@ class ImageCompressor {
return UIImage()
}

static func isCompressedSizeLessThanActualFile(sourceFileUrl: String,compressedFileUrl: String)-> Bool {
let sourceVideoURL = URL(string: sourceFileUrl)
let sourcefileSize:Double=Utils.getfileSizeInBytes(forURL:sourceVideoURL!)
static func isCompressedSizeLessThanActualFile(sourceFileUrl: String?, sourceData: Data?, compressedFileUrl: String)-> Bool {
var sourcefileSize: Int = 0

let compressedVideoURL = URL(string: compressedFileUrl)
let compressedfileSize:Double=Utils.getfileSizeInBytes(forURL:compressedVideoURL!)
if let _sourceFileUrl = sourceFileUrl {
let sourceVideoURL = URL(string: _sourceFileUrl)
sourcefileSize = Utils.getfileSizeInBytes(forURL: sourceVideoURL!)
}

if let _sourceData = sourceData {
sourcefileSize = _sourceData.count
}

let compressedFileURL = URL(string: compressedFileUrl)
let compressedfileSize = Utils.getfileSizeInBytes(forURL: compressedFileURL!)

if(compressedfileSize<=sourcefileSize)
{
return true
if compressedfileSize <= sourcefileSize {
return true
}

return false
}

static func isPNG(_ data: Data) -> Bool {
return data.starts(with: [0x89, 0x50, 0x4E, 0x47, 0x0D, 0x0A, 0x1A, 0x0A])
}

static func copyExifInfo(actualImagePath:String, image: UIImage, data: Data) -> Data {
static func copyExifInfo(actualImagePath: String, image: UIImage, data: Data) -> Data {
let fileURL = URL(string: actualImagePath)!
let filePath = fileURL.path

Expand Down Expand Up @@ -156,46 +164,45 @@ class ImageCompressor {
return destinationData as Data
}

static func writeImage(_ image: UIImage, output: Int, quality: Float, outputExtension: String, isBase64: Bool,disablePngTransparency:Bool,isEnableAutoCompress:Bool,actualImagePath:String)-> String{
static func writeImage(_ image: UIImage, output: Int, quality: Float, outputExtension: String, isBase64: Bool, disablePngTransparency: Bool, isEnableAutoCompress: Bool, actualImagePath: String?)-> String {
var data: Data
var exception: NSException?

switch OutputType(rawValue: output)! {
case .jpg:
data = image.jpegData(compressionQuality: CGFloat(quality))!
case .png:
if(disablePngTransparency)
{
if disablePngTransparency {
data = image.jpegData(compressionQuality: CGFloat(quality))!
let compressedImage = UIImage(data: data)
data = compressedImage!.pngData()!
} else {
data = image.pngData()!
}
else
{
data=image.pngData()!
}

}

data=copyExifInfo(actualImagePath: actualImagePath, image: UIImage(data: data) ?? image, data: data)

if let _actualImagePath = actualImagePath {
data = copyExifInfo(actualImagePath: _actualImagePath, image: UIImage(data: data) ?? image, data: data)
}

if isBase64 {
return data.base64EncodedString(options: [])
} else {
let filePath = Utils.generateCacheFilePath(outputExtension)

do {
try data.write(to: URL(fileURLWithPath: filePath), options: .atomic)
let returnablePath = makeValidUri(filePath)
if(isEnableAutoCompress==true)
{
if(self.isCompressedSizeLessThanActualFile(sourceFileUrl: actualImagePath,compressedFileUrl: returnablePath))
{

if isEnableAutoCompress == true {
if self.isCompressedSizeLessThanActualFile(sourceFileUrl: actualImagePath, sourceData: data, compressedFileUrl: returnablePath) {
return returnablePath
}
else
{
MediaCache.deleteFile(atPath:returnablePath)
return actualImagePath
} else {
MediaCache.deleteFile(atPath: returnablePath)

if let _actualImagePath = actualImagePath {
return _actualImagePath
}
}
}

Expand All @@ -210,8 +217,8 @@ class ImageCompressor {
}


static func manualCompress(_ image: UIImage, output: Int, quality: Float, outputExtension: String, isBase64: Bool,disablePngTransparency:Bool,actualImagePath:String) -> String {
return writeImage(image, output: output, quality: quality, outputExtension: outputExtension, isBase64: isBase64, disablePngTransparency: disablePngTransparency,isEnableAutoCompress: false,actualImagePath: actualImagePath)
static func manualCompress(_ image: UIImage, output: Int, quality: Float, outputExtension: String, isBase64: Bool, disablePngTransparency: Bool, actualImagePath: String?) -> String {
return writeImage(image, output: output, quality: quality, outputExtension: outputExtension, isBase64: isBase64, disablePngTransparency: disablePngTransparency, isEnableAutoCompress: false, actualImagePath: actualImagePath)
}


Expand Down Expand Up @@ -280,23 +287,27 @@ class ImageCompressor {
}


static func manualCompressHandler(_ imagePath: String, options: ImageCompressorOptions) -> String {
static func manualCompressHandler(imagePath: String?, base64: String?, options: ImageCompressorOptions) -> String {
var exception: NSException?
var image: UIImage?

switch options.input {
case .base64:
image = ImageCompressor.decodeImage(imagePath)
if let _base64 = base64 {
image = ImageCompressor.decodeImage(_base64)
}
case .uri:
image = ImageCompressor.loadImage(imagePath)
if let _imagePath = imagePath {
image = ImageCompressor.loadImage(_imagePath)
}
}

if let _image = image {
image = ImageCompressor.scaleAndRotateImage(_image)
let outputExtension = ImageCompressorOptions.getOutputInString(options.output)
let resizedImage = ImageCompressor.manualResize(image!, maxWidth: options.maxWidth, maxHeight: options.maxHeight)
let isBase64 = options.returnableOutputType == .rbase64
return ImageCompressor.manualCompress(resizedImage, output: options.output.rawValue, quality: options.quality, outputExtension: outputExtension, isBase64: isBase64,disablePngTransparency: options.disablePngTransparency,actualImagePath: imagePath)
return ImageCompressor.manualCompress(resizedImage, output: options.output.rawValue, quality: options.quality, outputExtension: outputExtension, isBase64: isBase64,disablePngTransparency: options.disablePngTransparency, actualImagePath: imagePath)
} else {
exception = NSException(name: NSExceptionName(rawValue: "unsupported_value"), reason: "Unsupported value type.", userInfo: nil)
exception?.raise()
Expand All @@ -306,9 +317,20 @@ class ImageCompressor {
}


static func autoCompressHandler(_ imagePath: String, options: ImageCompressorOptions) -> String {
static func autoCompressHandler(imagePath: String?, base64: String?, options: ImageCompressorOptions) -> String {
var exception: NSException?
var image = ImageCompressor.loadImage(imagePath)
var image: UIImage?

switch options.input {
case .base64:
if let _base64 = base64 {
image = ImageCompressor.decodeImage(_base64)
}
case .uri:
if let _imagePath = imagePath {
image = ImageCompressor.loadImage(_imagePath)
}
}

if var image = image {
image = ImageCompressor.scaleAndRotateImage(image)
Expand Down Expand Up @@ -343,9 +365,13 @@ class ImageCompressor {
let isBase64 = options.returnableOutputType == .rbase64

if let img = UIGraphicsGetImageFromCurrentImageContext() {
return writeImage(img, output: options.output.rawValue, quality: Float(compressionQuality), outputExtension: outputExtension, isBase64: isBase64, disablePngTransparency: options.disablePngTransparency,isEnableAutoCompress: true,actualImagePath: imagePath)
return writeImage(img, output: options.output.rawValue, quality: Float(compressionQuality), outputExtension: outputExtension, isBase64: isBase64, disablePngTransparency: options.disablePngTransparency, isEnableAutoCompress: true, actualImagePath: imagePath)
}
} else {
exception = NSException(name: NSExceptionName(rawValue: "unsupported_value"), reason: "Unsupported value type.", userInfo: nil)
exception?.raise()
}

return ""
}

Expand Down
21 changes: 16 additions & 5 deletions ios/Image/ImageMain.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,29 @@

import Foundation
class ImageMain {
static func image_compress(_ imagePath: String, optionMap: NSDictionary, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
static func image_compress(_ value: String, optionMap: NSDictionary, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
do {
let options = ImageCompressorOptions.fromDictionary(optionMap as! [String : Any])
ImageCompressor.getAbsoluteImagePath(imagePath, options: options) { absoluteImagePath in

if options.input != InputType.base64 {
ImageCompressor.getAbsoluteImagePath(value, options: options) { absoluteImagePath in
if options.autoCompress {
let result = ImageCompressor.autoCompressHandler(imagePath: absoluteImagePath, base64: nil, options: options)
resolve(result)
} else {
let result = ImageCompressor.manualCompressHandler(imagePath: absoluteImagePath, base64: nil, options: options)
resolve(result)
}
MediaCache.removeCompletedImagePath(absoluteImagePath)
}
} else {
if options.autoCompress {
let result = ImageCompressor.autoCompressHandler(absoluteImagePath, options: options)
let result = ImageCompressor.autoCompressHandler(imagePath: nil, base64: value, options: options)
resolve(result)
} else {
let result = ImageCompressor.manualCompressHandler(absoluteImagePath, options: options)
let result = ImageCompressor.manualCompressHandler(imagePath: nil, base64: value, options: options)
resolve(result)
}
MediaCache.removeCompletedImagePath(absoluteImagePath)
}
} catch {
reject(error.localizedDescription, error.localizedDescription, nil)
Expand Down
13 changes: 7 additions & 6 deletions ios/Utils/Utils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ class Utils {
}
}

static func getfileSizeInBytes(forURL url: Any) -> Double {
static func getfileSizeInBytes(forURL url: Any) -> Int {
var fileURL: URL?
var fileSize: Double = 0.0
var fileSize: Int = 0

if (url is URL) {
let urlWithSlash = Utils.slashifyFilePath(path: (url as? URL)?.absoluteString)
Expand All @@ -118,11 +118,12 @@ class Utils {
return fileSize
}

var fileSizeValue = 0.0
var fileSizeValue = 0

try? fileSizeValue = (fileURL?.resourceValues(forKeys: [URLResourceKey.fileSizeKey]).allValues.first?.value as! Double?)!
if fileSizeValue > 0.0 {
fileSize = Double(fileSizeValue)
try? fileSizeValue = (fileURL?.resourceValues(forKeys: [URLResourceKey.fileSizeKey]).allValues.first?.value as! Int)

if fileSizeValue > 0 {
fileSize = fileSizeValue
}

return fileSize
Expand Down