-
Notifications
You must be signed in to change notification settings - Fork 0
Add scripts to allow addons from personal repos to be synchronized with Crowdin #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… addedwith dev role to Crowdin if they use a project not owned by them to upload source files)
…flow to upload/update files in Crowdin
…k pass creating a PR at nvdaes/translateNvdaaddonsWithCrowdin repo
| strictSetInference = true | ||
|
|
||
| # Compliant rules | ||
| reportAbstractUsage = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably better to keep these rules than dropping to NVDA's standard
PurposeAdd-on authors may wish to help translators use Crowdin, the same framework where they translate NVDA. to translate messages and documentation for maintained add-ons: Other details
Development approachUse the Crowdin registration repo to add scripts usable by individual add-ons in personal repos. |
|
I've tested that all check pass using this pyproject.toml file on this PR: nvdaes/translateNvdaAddonsWithCrowdin#11 I use precommit, CodeQL and a workflow to check that all translatable messages have comments for translators. I'll try to use the cache action to cache some add-on metadata like its id, and also hashfiles from l10nSources (taking the value of buildVars.py), and the hasf¡hfile of the readme.md, to determine if pot and xliff files should be updated. |
|
Export translations to Crowdin running the workflow with update=False works properly: https://github.com/nvdaes/translateNvdaAddonsWithCrowdin/actions/runs/19802210157 |
|
This time, updatexLiff is failing. Seems that adding blank lines to readme may cause problems: https://github.com/nvdaes/translateNvdaAddonsWithCrowdin/actions/runs/19802391926/job/56731562709 |
|
If someone can help with this issue when update xliff, I'll be grateful. |
|
It might be easier to avoid xliff and just translate the markdown files directly. This won't support diffs very well but worth experimenting with |
|
@seanbudd wrote:
OK. |
|
@CyrilleB79, you were interested in this framework. If you want, feel free to see how the translateNvdaAddonsWithCrowdin.md can be translated in the project. Using xliff files is causing problems, as mentioned, and we are experimenting uploading md files instead. |
|
Lets get #4 and the submodule created first before working on this PR |
|
@seanbudd , I've created a repo with l10n files copied from NVDA master branch. Please let me know if we should create an addonTemplateBranch to be used for this repo, and the main branch for NVDA, or what do you think. The repo is at https://github.com/nvdaes/nvdaL10n License is GPL 3. I've selected this from available licenses. |
|
@seanbudd , I've created two branches for the nvdaL10n repo. Unless I've made some mistake, I've copied the NVDA files corresponding to l10nUtils and related ones to the main branch, and the modified files used in this PR, in the addonTemplate branch. You may add the submodule: The repo is managed by uv with a pyproject copied/based in the Pyproject used for the add-on template in PR #5 . |
…cording to uv version
|
Seems that we cannot run pre-commit inside GitHub Actions, and that that steps should be removed. In this case nothing is updated since the readme and i18nsources hashes are the same. |
No description provided.