Skip to content

Conversation

@nvdaes
Copy link

@nvdaes nvdaes commented Dec 16, 2025

### Description

This PR updates Pyproject.

@seanbudd, I advice to pay speciall attention to Pyright. Should we exclude _l10n?

I'm not sure about running Pyright locally on my computer...

@seanbudd
Copy link
Member

I think we should try to handle l10n in its own repo

pyproject.toml Outdated
Comment on lines 24 to 32
"crowdin-api-client==1.21.0",
"lxml>=6.0.2",
"markdown>=3.10",
"markdown-link-attr-modifier==0.2.1",
"mdx-gh-links==0.4",
"mdx-truly-sane-lists==1.3",
"nh3==0.2.19",
"requests>=2.32.5",
"scons==4.10.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all of these required for the current state? or are some only necessary with #1 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except scons, they are required just for pr #1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you separate the ones only required for the submodule and #1, to those PRs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to do it, but then merging caused conflicts and it was difficult for testing. So I've updated pyproject here with all required dependencies with some comments before each group.

@nvdaes
Copy link
Author

nvdaes commented Dec 20, 2025

I've managed to run Pyright locally by looking at NVDA repo, using uv run pre-commit run --all-files.
And Pyright doesn't recognize the reportShadowedImports key, nor the lint section of the pyproject file. In pr #1 I've added Pyright to the dependencies sections along with pre-commit. I'd like to use a hook used in NVDA to verify the lock file for uv in the workflow. In this case precommit yaml file needs to be modified, perhaps all this in PR #1. I'm making tests and the setOutput.py file has been updated too there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants