-
Notifications
You must be signed in to change notification settings - Fork 0
Update pyproject #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I think we should try to handle l10n in its own repo |
pyproject.toml
Outdated
| "crowdin-api-client==1.21.0", | ||
| "lxml>=6.0.2", | ||
| "markdown>=3.10", | ||
| "markdown-link-attr-modifier==0.2.1", | ||
| "mdx-gh-links==0.4", | ||
| "mdx-truly-sane-lists==1.3", | ||
| "nh3==0.2.19", | ||
| "requests>=2.32.5", | ||
| "scons==4.10.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all of these required for the current state? or are some only necessary with #1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except scons, they are required just for pr #1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you separate the ones only required for the submodule and #1, to those PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to do it, but then merging caused conflicts and it was difficult for testing. So I've updated pyproject here with all required dependencies with some comments before each group.
|
I've managed to run Pyright locally by looking at NVDA repo, using |
### Description
This PR updates Pyproject.
@seanbudd, I advice to pay speciall attention to Pyright. Should we exclude _l10n?
I'm not sure about running Pyright locally on my computer...