Skip to content

fix: Container settings sidebar hidden in overflow menu #2468 #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Container settings sidebar hidden in overflow menu #2468 #2475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97a805d
fix: Container settings sidebar hidden in overflow menu #2468
Sep 23, 2025
939b413
Merge branch 'master' into ahtesham/#2468
Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 49 additions & 36 deletions src/library-authoring/containers/ContainerInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ import { FormattedMessage, useIntl } from '@edx/frontend-platform/i18n';
import {
Button,
Stack,
Tab,
Tabs,
Dropdown,
Icon,
IconButton,
useToggle,
} from '@openedx/paragon';
// eslint-disable-next-line import/no-extraneous-dependencies
import { Tab, Nav } from 'react-bootstrap';
Comment on lines +10 to +11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be directly importing from react-bootstrap. That's what the eslint warning import/no-extraneous-dependencies is trying to tell you.

Future versions of Paragon may be refactored to not use bootstrap at all, so we should only use Paragon APIs.

import React, { useCallback } from 'react';
import { Link } from 'react-router-dom';
import { MoreVert } from '@openedx/paragon/icons';
Expand Down Expand Up @@ -39,7 +39,6 @@ type ContainerPreviewProps = {

const ContainerMenu = ({ containerId }: ContainerPreviewProps) => {
const intl = useIntl();

const [isConfirmingDelete, confirmDelete, cancelDelete] = useToggle(false);

return (
Expand Down Expand Up @@ -159,23 +158,21 @@ const ContainerInfo = () => {
sidebarTab && isContainerInfoTab(sidebarTab)
) ? sidebarTab : defaultContainerTab;

/* istanbul ignore next */
const handleTabChange = (newTab: ContainerInfoTab) => {
resetSidebarAction();
setSidebarTab(newTab);
};

const renderTab = useCallback((infoTab: ContainerInfoTab, title: string, component?: React.ReactNode) => {
const renderTab = useCallback((infoTab: ContainerInfoTab, title: string) => {
if (hiddenTabs.includes(infoTab)) {
// For some reason, returning anything other than empty list breaks the tab style
return [];
return null;
}
return (
<Tab eventKey={infoTab} title={title}>
{component}
</Tab>
<Nav.Item key={infoTab}>
<Nav.Link eventKey={infoTab}>{title}</Nav.Link>
</Nav.Item>
);
}, [hiddenTabs, defaultContainerTab, containerId]);
}, [hiddenTabs]);

if (!container || !containerId || !containerType) {
return null;
Expand All @@ -188,34 +185,50 @@ const ContainerInfo = () => {
containerType={containerType}
hasUnpublishedChanges={container.hasUnpublishedChanges}
/>
<Tabs
variant="tabs"
className="my-3 d-flex justify-content-around"

<Tab.Container
defaultActiveKey={defaultContainerTab}
activeKey={tab}
onSelect={handleTabChange}
onSelect={(k) => handleTabChange(k as ContainerInfoTab)}
mountOnEnter
unmountOnExit
>
{renderTab(
CONTAINER_INFO_TABS.Preview,
intl.formatMessage(messages.previewTabTitle),
<ContainerPreview containerId={containerId} />,
)}
{renderTab(
CONTAINER_INFO_TABS.Manage,
intl.formatMessage(messages.manageTabTitle),
<ContainerOrganize />,
)}
{renderTab(
CONTAINER_INFO_TABS.Usage,
intl.formatMessage(messages.usageTabTitle),
<ContainerUsage />,
)}
{renderTab(
CONTAINER_INFO_TABS.Settings,
intl.formatMessage(messages.settingsTabTitle),
// TODO: container settings component
)}
</Tabs>
<Nav variant="tabs" className="my-3 d-flex justify-content-around">
{renderTab(
CONTAINER_INFO_TABS.Preview,
intl.formatMessage(messages.previewTabTitle),
)}
{renderTab(
CONTAINER_INFO_TABS.Manage,
intl.formatMessage(messages.manageTabTitle),
)}
{renderTab(
CONTAINER_INFO_TABS.Usage,
intl.formatMessage(messages.usageTabTitle),
)}
{/* 👇 Always show Settings */}
<Nav.Item>
<Nav.Link eventKey={CONTAINER_INFO_TABS.Settings}>
{intl.formatMessage(messages.settingsTabTitle)}
</Nav.Link>
</Nav.Item>
</Nav>

<Tab.Content className="mt-3">
<Tab.Pane eventKey={CONTAINER_INFO_TABS.Preview}>
<ContainerPreview containerId={containerId} />
</Tab.Pane>
<Tab.Pane eventKey={CONTAINER_INFO_TABS.Manage}>
<ContainerOrganize />
</Tab.Pane>
<Tab.Pane eventKey={CONTAINER_INFO_TABS.Usage}>
<ContainerUsage />
</Tab.Pane>
<Tab.Pane eventKey={CONTAINER_INFO_TABS.Settings}>
{/* TODO: Container settings component */}
</Tab.Pane>
</Tab.Content>
</Tab.Container>
</Stack>
);
};
Expand Down