fix: Container settings sidebar hidden in overflow menu #2468 #2475
Conversation
ahtesham-quraish
force-pushed
the
ahtesham/#2468
branch
2 times, most recently
from
8d63f8b to
5eb64ab
Compare
ahtesham-quraish
force-pushed
the
ahtesham/#2468
branch
from
5eb64ab to
97a805d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2475 +/- ##
==========================================
- Coverage 94.71% 94.70% -0.01%
==========================================
Files 1202 1202
Lines 26845 26850 +5
Branches 6025 5873 -152
==========================================
+ Hits 25425 25429 +4
- Misses 1350 1362 +12
+ Partials 70 59 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @ChrisChV @bradenmacdonald, @ahtesham-quraish has created this PR to fix the bug where the settings tab is hidden in an overflow menu for review when available! Thank you @ahtesham-quraish! |
fix: merge with master
There was a problem hiding this comment.
I think this needs to be fixed in Paragon instead of just hacking around it in this MFE. The problem seems to be https://github.com/openedx/paragon/blob/67977fc39923eaae1fed08a0f0a99de295fc8b07/src/hooks/useIndexOfLastVisibleChildHook.tsx#L42-L45 and I think we can update it to use a more complicated calculation that never shows "a dropdown with one item when it would fit".
| // eslint-disable-next-line import/no-extraneous-dependencies | ||
| import { Tab, Nav } from 'react-bootstrap'; |
There was a problem hiding this comment.
We should not be directly importing from react-bootstrap. That's what the eslint warning import/no-extraneous-dependencies is trying to tell you.
Future versions of Paragon may be refactored to not use bootstrap at all, so we should only use Paragon APIs.
3 participants
Description
Container settings sidebar hidden in overflow menu #2468
Supporting information