Adding invertMarking flag to ModuleHasDependency for flipping what gets marked
#146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…witch between marking files part of a module with a dependency (default / original behaviour / when flag is set to false or not provided) and marking files part of a module that doesn't have a dependency (when the flag is set to true)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/dependencies/search/ModuleHasDependency.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/dependencies/search/ModuleHasDependencyTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/dependencies/search/ModuleHasDependencyTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/dependencies/search/ModuleHasDependencyTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/dependencies/search/ModuleHasDependencyTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/dependencies/search/ModuleHasDependencyTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/dependencies/search/ModuleHasDependencyTest.java
Outdated
Show resolved
Hide resolved
steve-aom-elliott
force-pushed
the
module-has-dependency-invert-marking-option
branch
from
8edc123 to
f7cea50
Compare
sambsnyd
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
invertMarkingoptional boolean flag added toModuleHasDependencythat flips what files get marked during the visitor (and changes the message fromModule has dependency: ...toModule does not have dependency: ...when flipping.What's your motivation?
To allow it to switch between marking files part of a module with a dependency (default / original behaviour / when flag is set to false or not provided) and marking files part of a module that doesn't have a dependency (when the flag is set to true)
org.testng:testng. rewrite-testing-frameworks#760 (comment)Checklist