-
Notifications
You must be signed in to change notification settings - Fork 21
WIP Fixes #47 - support default and custom defined/freeform tags #144
base: master
Are you sure you want to change the base?
Conversation
e4dfa89 to
2179679
Compare
|
So i've modified the original issue to be more generic. Also, the aws cluster pattern isn't supported in OCI because it contains a period, which would act as a namespace and not allowed in freeform tags. This now supports default defined and freeform tags via an env var The format for both is comma separated list of defined & freeform tags: My thinking is we could use the exact same logic/annotations/env var in other services like the CCM to tag services. |
|
FYI, the e2e tests seem flake kinda often. |
|
@owainlewis thoughts on this implementation? |
| ociVolumeBackupID = "volume.beta.kubernetes.io/oci-volume-source" | ||
| ociVolumeID = "ociVolumeID" | ||
| ociVolumeBackupID = "volume.beta.kubernetes.io/oci-volume-source" | ||
| ociTagAnnotation = "oraclecloud.com/additional-tags" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oracle.com/additional-tags would be more consistent here with things like the flex driver e.g. oracle.com/oci as the provisioner name.
|
@jhorwit2 I like the implementation. I would prefer |
The tag / value here is based on the aws in-tree provider which tags resources based on the cluster name and whether or not the cluster owns it or not.