fix: adjust workspace, and resolve failing CI tests #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-jonas
commented
Sep 2, 2025
| subcommand: "project", | ||
| pathSuccess: "fixtures/update/json/config.json", | ||
| pathFailure: "fixtures/update/fail/config.json", | ||
| failureContains: "minimum 1 items allowed", |
Member
Author
There was a problem hiding this comment.
I don't understand how this ever passed.. Both the fixture used and the error message in Ory Network are 2+ years old, but the error message definitely should the updated one...
jonas-jonas
commented
Sep 2, 2025
Comment on lines
+10
to
+11
| schedule: | ||
| - cron: "0 0 * * *" |
Member
Author
There was a problem hiding this comment.
As we have very little "traffic" on this repository we often don't notice if something breaks in these tests until much later (e.g. a customer reports an issue or someone creates a PR). So I think it makes sense to run these tests on a schedule.
@adamwalach I'd like to add a slack notification if this workflow fails, but only if it ran from a schedule. Can you help?
jonas-jonas
changed the title
jonas-jonas
changed the title
shaunnkhan
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).
Further comments