Skip to content

fix: adjust workspace, and resolve failing CI tests #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonas-jonas merged 2 commits into from
Sep 3, 2025
Merged

fix: adjust workspace, and resolve failing CI tests #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7ab776
chore: update workspace & project in GHA Integration test
jonas-jonas Aug 26, 2025
703ffbf
chore: u
jonas-jonas Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ on:
tags:
- "*"
pull_request:
schedule:
- cron: "0 0 * * *"
Comment on lines +10 to +11
Copy link
Member Author

@jonas-jonas jonas-jonas Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have very little "traffic" on this repository we often don't notice if something breaks in these tests until much later (e.g. a customer reports an issue or someone creates a PR). So I think it makes sense to run these tests on a schedule.

@adamwalach I'd like to add a slack notification if this workflow fails, but only if it ran from a schedule. Can you help?


jobs:
test:
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/test-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ on:
- master

env:
ORY_PROJECT_ID: "6c2ec103-0b67-4cfe-a975-8008ede7d2ff"
ORY_WORKSPACE_ID: "d4c796bf-6062-4cf0-87fc-5fcbf41743bb"
# project & workspace are managed in Ory Cloud tech integration workspace.
ORY_PROJECT_ID: "3b188173-833c-4074-995c-9085a72c8112"
ORY_WORKSPACE_ID: "f77d4982-46f1-42cd-8d02-8bccfa54f8f7"
ORY_WORKSPACE_API_KEY: ${{ secrets.ORY_WORKSPACE_API_KEY }}

jobs:
Expand Down
4 changes: 2 additions & 2 deletions cmd/cloudx/project/update_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ func TestUpdateProject(t *testing.T) {
subcommand: "project",
pathSuccess: "fixtures/update/json/config.json",
pathFailure: "fixtures/update/fail/config.json",
failureContains: "minimum 1 items allowed",
Copy link
Member Author

@jonas-jonas jonas-jonas Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this ever passed.. Both the fixture used and the error message in Ory Network are 2+ years old, but the error message definitely should the updated one...

failureContains: "field `identities.default_schema_id` can not be empty",
fixture: fixtureProject,
},
{
subcommand: "identity-config",
projectFlag: "--project",
pathSuccess: "fixtures/update-kratos/json/config.json",
pathFailure: "fixtures/update-kratos/fail/config.json",
failureContains: "minimum 1 items allowed",
failureContains: "field `identities.default_schema_id` can not be empty",
fixture: fixtureKratosConfig,
},
{
Expand Down
Loading