-
-
Notifications
You must be signed in to change notification settings - Fork 670
feat(formatter): normalize key of TSPropertySignature
#14083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(formatter): normalize key of TSPropertySignature
#14083
Conversation
CodSpeed Instrumentation Performance ReportMerging #14083 will not alter performanceComparing Summary
Footnotes
|
726e28f
to
47e0819
Compare
33f6166
to
495dddf
Compare
495dddf
to
9dc5d63
Compare
47e0819
to
453f528
Compare
Merge activity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes formatter handling of TypeScript property signature keys by normalizing them through the proper formatting function. The change improves compatibility with Prettier's output format.
- Replaces direct key writing with
format_property_key
for non-computed TypeScript property signatures - Increases Prettier compatibility from 528/573 (92.15%) to 529/573 (92.32%)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
crates/oxc_formatter/src/write/mod.rs | Updates TSPropertySignature formatting to use format_property_key for non-computed keys |
tasks/prettier_conformance/snapshots/prettier.ts.snap.md | Reflects improved test compatibility score and removal of previously failing test case |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
7c21667
to
90fd46f
Compare
No description provided.