Skip to content

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Sep 24, 2025

No description provided.

@github-actions github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Sep 24, 2025
Copy link
Member Author

Dunqing commented Sep 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Sep 24, 2025

CodSpeed Instrumentation Performance Report

Merging #14083 will not alter performance

Comparing 09-24-feat_formatter_normalize_key_of_tspropertysignature (90fd46f) with main (46cceb8)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing force-pushed the 09-24-feat_formatter_normalize_key_of_tspropertysignature branch from 726e28f to 47e0819 Compare September 25, 2025 01:10
@Dunqing Dunqing force-pushed the 09-24-fix_formatter_correct_printing_comments_within_the_type_annotation_of_arraypattern_and_objectpattern branch from 33f6166 to 495dddf Compare September 25, 2025 01:10
@Dunqing Dunqing marked this pull request as ready for review September 26, 2025 11:57
@Dunqing Dunqing force-pushed the 09-24-fix_formatter_correct_printing_comments_within_the_type_annotation_of_arraypattern_and_objectpattern branch from 495dddf to 9dc5d63 Compare September 26, 2025 16:42
@Dunqing Dunqing force-pushed the 09-24-feat_formatter_normalize_key_of_tspropertysignature branch from 47e0819 to 453f528 Compare September 26, 2025 16:42
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Sep 29, 2025
@graphite-app graphite-app bot changed the base branch from 09-24-fix_formatter_correct_printing_comments_within_the_type_annotation_of_arraypattern_and_objectpattern to graphite-base/14083 September 29, 2025 09:38
Copy link
Contributor

graphite-app bot commented Sep 29, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 29, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/14083 to main September 29, 2025 09:51
@Copilot Copilot AI review requested due to automatic review settings September 29, 2025 12:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes formatter handling of TypeScript property signature keys by normalizing them through the proper formatting function. The change improves compatibility with Prettier's output format.

  • Replaces direct key writing with format_property_key for non-computed TypeScript property signatures
  • Increases Prettier compatibility from 528/573 (92.15%) to 529/573 (92.32%)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_formatter/src/write/mod.rs Updates TSPropertySignature formatting to use format_property_key for non-computed keys
tasks/prettier_conformance/snapshots/prettier.ts.snap.md Reflects improved test compatibility score and removal of previously failing test case

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Sep 29, 2025
@graphite-app graphite-app bot force-pushed the 09-24-feat_formatter_normalize_key_of_tspropertysignature branch from 7c21667 to 90fd46f Compare September 29, 2025 12:52
@graphite-app graphite-app bot merged commit 90fd46f into main Sep 29, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 09-24-feat_formatter_normalize_key_of_tspropertysignature branch September 29, 2025 12:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-formatter Area - Formatter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants