Skip to content

Conversation

leaysgur
Copy link
Member

@leaysgur leaysgur commented Oct 2, 2025

Part of #14253

Implement sortSideEffects option, default false.

If true, side-effect imports are also sorted with other imports.

@github-actions github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Oct 2, 2025
Copy link
Member Author

leaysgur commented Oct 2, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Oct 2, 2025

CodSpeed Instrumentation Performance Report

Merging #14293 will not alter performance

Comparing 10-02-feat_formatter_sort-imports_implement_options.sortsideeffects_bool (1d7b524) with 10-02-feat_formatter_sort-imports_add_options.order_asc_desc (a3a8fc4)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur force-pushed the 10-02-feat_formatter_sort-imports_implement_options.sortsideeffects_bool branch from f187f9d to 1d7b524 Compare October 2, 2025 06:24
@leaysgur leaysgur marked this pull request as ready for review October 2, 2025 06:30
@leaysgur leaysgur requested a review from Dunqing as a code owner October 2, 2025 06:30
@leaysgur leaysgur marked this pull request as draft October 2, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-formatter Area - Formatter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant