fix(tasks/lint_rules): update import syntax for `eslint-plugin-react-hooks` #14305

Sysix · 2025-10-02T18:50:33Z

https://github.com/oxc-project/oxc/actions/runs/18187752358/job/51775645436

node tasks/lint_rules

works again without a problem.

#1022

`node tasks/lint_rules --target react`

[!WARNING]
This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is tracking issue for eslint-plugin-react, eslint-plugin-react-hooks.

There are 130(+ 2 deprecated) rules.

21/39 recommended rules are remaining as TODO
64/91 not recommended rules are remaining as TODO

To get started, run the following command:

just new-react-rule <RULE_NAME>

Then register the rule in crates/oxc_linter/src/rules.rs and also declare_all_lint_rules at the bottom.

Recommended rules

✨: 18, 🚫: 0 / total: 39

Status	Name	Docs
	react/display-name	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/display-name.md
✨	react/jsx-key	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-key.md
✨	react/jsx-no-comment-textnodes	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-comment-textnodes.md
✨	react/jsx-no-duplicate-props	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-duplicate-props.md
✨	react/jsx-no-target-blank	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-target-blank.md
✨	react/jsx-no-undef	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-undef.md
	react/jsx-uses-react	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-uses-react.md
	react/jsx-uses-vars	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-uses-vars.md
✨	react/no-children-prop	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-children-prop.md
✨	react/no-danger-with-children	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-danger-with-children.md
	react/no-deprecated	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-deprecated.md
✨	react/no-direct-mutation-state	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-direct-mutation-state.md
✨	react/no-find-dom-node	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-find-dom-node.md
✨	react/no-is-mounted	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-is-mounted.md
✨	react/no-string-refs	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-string-refs.md
✨	react/no-render-return-value	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-render-return-value.md
✨	react/no-unescaped-entities	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-unescaped-entities.md
✨	react/no-unknown-property	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-unknown-property.md
	react/prop-types	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/prop-types.md
✨	react/react-in-jsx-scope	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/react-in-jsx-scope.md
✨	react/require-render-return	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/require-render-return.md
✨	react/exhaustive-deps	facebook/react#14920
✨	react/rules-of-hooks	https://react.dev/reference/rules/rules-of-hooks
	react/no-unused-directives
	react/static-components
	react/use-memo
	react/component-hook-factories
	react/preserve-manual-memoization
	react/incompatible-library
	react/immutability
	react/globals
	react/refs
	react/set-state-in-effect
	react/error-boundaries
	react/purity
	react/set-state-in-render
	react/unsupported-syntax
	react/config
	react/gating

✨ = Implemented, 🚫 = No need to implement

Not recommended rules

✨: 22, 🚫: 5 / total: 91

Status	Name	Docs
	react/boolean-prop-naming	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/boolean-prop-naming.md
✨	react/button-has-type	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/button-has-type.md
✨	react/checked-requires-onchange-or-readonly	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/checked-requires-onchange-or-readonly.md
	react/default-props-match-prop-types	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/default-props-match-prop-types.md
	react/destructuring-assignment	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/destructuring-assignment.md
	react/forbid-component-props	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/forbid-component-props.md
	react/forbid-dom-props	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/forbid-dom-props.md
✨	react/forbid-elements	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/forbid-elements.md
	react/forbid-foreign-prop-types	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/forbid-foreign-prop-types.md
	react/forbid-prop-types	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/forbid-prop-types.md
✨	react/forward-ref-uses-ref	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/forward-ref-uses-ref.md
	react/function-component-definition	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/function-component-definition.md
	react/hook-use-state	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/hook-use-state.md
✨	react/iframe-missing-sandbox	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/iframe-missing-sandbox.md
✨	react/jsx-boolean-value	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-boolean-value.md
	react/jsx-child-element-spacing	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-child-element-spacing.md
	react/jsx-closing-bracket-location	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-closing-bracket-location.md
	react/jsx-closing-tag-location	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-closing-tag-location.md
🚫	react/jsx-curly-spacing	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-curly-spacing.md
	react/jsx-curly-newline	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-curly-newline.md
🚫	react/jsx-equals-spacing	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-equals-spacing.md
✨	react/jsx-filename-extension	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-filename-extension.md
	react/jsx-first-prop-new-line	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-first-prop-new-line.md
✨	react/jsx-handler-names	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-handler-names.md
🚫	react/jsx-indent	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-indent.md
🚫	react/jsx-indent-props	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-indent-props.md
	react/jsx-max-depth	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-max-depth.md
	react/jsx-max-props-per-line	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-max-props-per-line.md
	react/jsx-newline	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-newline.md
	react/jsx-no-bind	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-bind.md
	react/jsx-no-constructed-context-values	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-constructed-context-values.md
	react/jsx-no-leaked-render	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-leaked-render.md
	react/jsx-no-literals	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-literals.md
✨	react/jsx-no-script-url	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-script-url.md
✨	react/jsx-no-useless-fragment	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-useless-fragment.md
	react/jsx-one-expression-per-line	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-one-expression-per-line.md
✨	react/jsx-curly-brace-presence	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-curly-brace-presence.md
✨	react/jsx-pascal-case	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-pascal-case.md
✨	react/jsx-fragments	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-fragments.md
🚫	react/jsx-props-no-multi-spaces	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-props-no-multi-spaces.md
	react/jsx-props-no-spreading	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-props-no-spreading.md
✨	react/jsx-props-no-spread-multi	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-props-no-spread-multi.md
	react/jsx-sort-props	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-sort-props.md
	react/jsx-tag-spacing	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-tag-spacing.md
	react/jsx-wrap-multilines	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-wrap-multilines.md
	react/no-invalid-html-attribute	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-invalid-html-attribute.md
	react/no-access-state-in-setstate	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-access-state-in-setstate.md
	react/no-adjacent-inline-elements	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-adjacent-inline-elements.md
✨	react/no-array-index-key	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-array-index-key.md
	react/no-arrow-function-lifecycle	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-arrow-function-lifecycle.md
✨	react/no-danger	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-danger.md
	react/no-did-mount-set-state	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-did-mount-set-state.md
	react/no-did-update-set-state	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-did-update-set-state.md
	react/no-multi-comp	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-multi-comp.md
✨	react/no-namespace	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-namespace.md
✨	react/no-set-state	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-set-state.md
	react/no-redundant-should-component-update	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-redundant-should-component-update.md
	react/no-this-in-sfc	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-this-in-sfc.md
	react/no-typos	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-typos.md
	react/no-unsafe	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-unsafe.md
	react/no-unstable-nested-components	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-unstable-nested-components.md
	react/no-unused-class-component-methods	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-unused-class-component-methods.md
	react/no-unused-prop-types	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-unused-prop-types.md
	react/no-unused-state	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-unused-state.md
	react/no-object-type-as-default-prop	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-object-type-as-default-prop.md
	react/no-will-update-set-state	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/no-will-update-set-state.md
✨	react/prefer-es6-class	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/prefer-es6-class.md
	react/prefer-exact-props	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/prefer-exact-props.md
	react/prefer-read-only-props	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/prefer-read-only-props.md
	react/prefer-stateless-function	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/prefer-stateless-function.md
	react/require-default-props	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/require-default-props.md
	react/require-optimization	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/require-optimization.md
✨	react/self-closing-comp	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/self-closing-comp.md
	react/sort-comp	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/sort-comp.md
	react/sort-default-props	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/sort-default-props.md
	react/sort-prop-types	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/sort-prop-types.md
	react/state-in-constructor	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/state-in-constructor.md
	react/static-property-placement	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/static-property-placement.md
✨	react/style-prop-object	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/style-prop-object.md
✨	react/void-dom-elements-no-children	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/void-dom-elements-no-children.md
	react/hooks
	react/capitalized-calls
	react/memoized-effect-dependencies
	react/no-deriving-state-in-effects
	react/invariant
	react/todo
	react/syntax
	react/rule-suppression
	react/automatic-effect-dependencies
	react/fire
	react/fbt

✨ = Implemented, 🚫 = No need to implement

Deprecated rules

✨: 0, 🚫: 0 / total: 2

Status	Name	Docs
	react/jsx-sort-default-props	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-sort-default-props.md
	react/jsx-space-before-closing	https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-space-before-closing.md

✨ = Implemented, 🚫 = No need to implement

Some rules do not have docs urls. The URL comes from the plugin:

{
  meta: {
    type: 'problem',
    docs: {
      description: 'enforces the Rules of Hooks',
      recommended: true,
      url: 'https://react.dev/reference/rules/rules-of-hooks'
    },
    schema: [ [Object] ]
  },
  create: [Function: create]
}
{
  meta: {
    type: 'suggestion',
    docs: { recommended: true },
    fixable: 'code',
    hasSuggestions: true,
    schema: [ [Object] ]
  },
  create: [Function: create]
}

Sysix · 2025-10-02T18:50:50Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR fixes an import issue in the lint rules task by updating the import syntax for eslint-plugin-react-hooks to use the default export instead of destructuring the rules property directly.

Key Changes

Updated import statement for eslint-plugin-react-hooks to use default import
Added explicit destructuring of the rules property with a TypeScript error suppression comment

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tasks/lint_rules/src/eslint-rules.mjs

camc314 · 2025-10-06T07:48:26Z

Merge activity

Oct 6, 7:48 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 6, 7:48 AM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 6, 7:53 AM UTC: Merged by the Graphite merge queue.

github-actions bot added the C-bug Category - Bug label Oct 2, 2025

Sysix marked this pull request as ready for review October 2, 2025 19:14

Copilot AI review requested due to automatic review settings October 2, 2025 19:14

Copilot AI reviewed Oct 2, 2025

View reviewed changes

tasks/lint_rules/src/eslint-rules.mjs Show resolved Hide resolved

Sysix force-pushed the 10-02-fix_tasks_lint_rules_update_import_syntax_for_eslint-plugin-react-hooks_ branch from 2d6519e to 3e305cd Compare October 2, 2025 20:22

This was referenced Oct 2, 2025

chore(tasks/lint_rules): unsupport more vue rules #14306

Merged

feat(linter): add vue/no-export-in-script-setup rule #14307

Merged

Sysix force-pushed the 10-02-fix_tasks_lint_rules_update_import_syntax_for_eslint-plugin-react-hooks_ branch from 3e305cd to bba1d1d Compare October 4, 2025 15:48

This was referenced Oct 4, 2025

feat(linter): add vue/no-import-compiler-macros rule #14335

Merged

feat(linter): add vue/require-default-export rule #14351

Merged

camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 6, 2025

graphite-app bot force-pushed the 10-02-fix_tasks_lint_rules_update_import_syntax_for_eslint-plugin-react-hooks_ branch from bba1d1d to f46b2c6 Compare October 6, 2025 07:48

graphite-app bot merged commit f46b2c6 into main Oct 6, 2025
17 checks passed

graphite-app bot deleted the 10-02-fix_tasks_lint_rules_update_import_syntax_for_eslint-plugin-react-hooks_ branch October 6, 2025 07:53

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(tasks/lint_rules): update import syntax for `eslint-plugin-react-hooks` #14305

fix(tasks/lint_rules): update import syntax for `eslint-plugin-react-hooks` #14305

Sysix commented Oct 2, 2025 •

edited

Loading

Uh oh!

Sysix commented Oct 2, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

camc314 commented Oct 6, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(tasks/lint_rules): update import syntax for eslint-plugin-react-hooks #14305

fix(tasks/lint_rules): update import syntax for eslint-plugin-react-hooks #14305

Conversation

Sysix commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Recommended rules

Not recommended rules

Deprecated rules

Uh oh!

Sysix commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Uh oh!

Uh oh!

camc314 commented Oct 6, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(tasks/lint_rules): update import syntax for `eslint-plugin-react-hooks` #14305

fix(tasks/lint_rules): update import syntax for `eslint-plugin-react-hooks` #14305

Sysix commented Oct 2, 2025 •

edited

Loading

Sysix commented Oct 2, 2025 •

edited

Loading

camc314 commented Oct 6, 2025 •

edited by graphite-app bot

Loading