feat(linter): add `vue/require-default-export` rule #14351

Sysix · 2025-10-05T12:20:42Z

https://eslint.vuejs.org/rules/require-default-export

Sysix · 2025-10-05T12:21:04Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-10-05T12:25:59Z

CodSpeed Performance Report

Merging #14351 will not alter performance

_{Comparing 10-05-feat_linter_add_vue_require-default-export_rule (83e7824) with main (8f056ad)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

No successful run was found on main (83e7824) during the generation of this report, so 8f056ad was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull Request Overview

This PR implements a new Vue linter rule vue/require-default-export that enforces Vue Single File Components to have a default export. The rule helps ensure compatibility with Vue 3 by requiring components to be exported as the default export.

Key changes:

Added a new linter rule that detects missing default exports in Vue SFC script sections
Implemented logic to differentiate between missing exports and Vue components that should be default exports
Added comprehensive test coverage for various scenarios

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_linter/src/rules/vue/require_default_export.rs	New rule implementation with diagnostic logic and comprehensive test cases
crates/oxc_linter/src/rules.rs	Module registration and rule declaration
crates/oxc_linter/src/context/host.rs	Added framework_options accessor method
crates/oxc_linter/src/snapshots/vue_require_default_export.snap	Test snapshot output for rule validation

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/rules/vue/require_default_export.rs

camc314 · 2025-10-07T16:03:55Z

Merge activity

Oct 7, 4:03 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 7, 4:03 PM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 7, 4:08 PM UTC: Merged by the Graphite merge queue.

https://eslint.vuejs.org/rules/require-default-export related #11440

## [1.21.0] - 2025-10-08 ### 🚀 Features - 576be20 linter/plugins: Support selectors DSL (#14435) (overlookmotel) - b2de44f linter/plugins: Support interpolation in normal diagnostic `message` (#14419) (overlookmotel) - 382c5be linter/plugins: Support placeholders in messageIds (#14416) (camc314) - 529e88e linter/plugins: Support `messageId`s (#14415) (camc314) - 83e7824 linter: Add `vue/require-default-export` rule (#14351) (Sysix) - ff98536 linter: Add `vue/no-import-compiler-macros` rule (#14335) (Sysix) - 0ec0847 ci: Run napi tests on windows (#14383) (camc314) ### 🐛 Bug Fixes - 11e0440 linter/jsx-handler-name: Improve handler name position in error messages (#14174) (Takuji Shimokawa) - 493082c language_server: Use the first Span of the message as the primary Diagnostic range (#14057) (Sysix) - 88ec1bd linter/plugins: Fix error messages (#14423) (overlookmotel) - 18616c2 oxlint: Ignore fixtures dir for vitest (#14414) (camc314) - ec02fe8 oxlint: Normalize path separators in snapshot tests (#14406) (camc314) - 6e8d2f6 language_server: Ignore JS plugins (#14379) (overlookmotel) - 96663fb linter/plugins: Do not call `before` hook if empty visitor (#14401) (overlookmotel) - 52f04bd linter: Use `pathToFileURL` for importing plugins to ensure correct URL format (#14394) (camc314) - 1ea0d46 oxlint: Resolve tsdown deprecation warning (#14389) (camc314) - bb679b5 linter: Promise/prefer-await-to-then strict option not reading from config (#14382) (camc314) ### 🚜 Refactor - 3374b8e linter/language_server: Move all lsp relevant code to `oxc_language_server` crate (#14430) (Sysix) - d24b74e linter/language_server: `oxc_linter::TsgoLinter::run_source` returns `Message` (#14429) (Sysix) - e5b7fb2 linter/language_server: `oxc_linter::Runtime::run_source` returns `Message` (#14428) (Sysix) - 3b26bf3 linter/plugins: Split adding visit function to compiler visitor into multiple functions (#14433) (overlookmotel) - af3a75e linter/plugins: Track ancestors while walking AST (#14432) (overlookmotel) - f279f0b linter/plugins: Do not lazy-load visitor keys (#14431) (overlookmotel) - 5e99ed3 linter/plugins: Allow nullish values as `message` or `messageId` (#14422) (overlookmotel) - dc30938 linter/plugins: Remove default value from `Context` constructor (#14421) (overlookmotel) - 28cfae0 oxlint: Use `vitest`s built in file snapshot comparison (#14392) (camc314) - 06b0e9f linter/plugins: Convert generated files to TS (#14385) (overlookmotel) - 52f35c6 napi/parser, linter/plugins: Rename `types.js` to `type_ids.js` (#14384) (overlookmotel) ### ⚡ Performance - 26435a1 linter/plugins: Small perf optimizations (#14420) (overlookmotel) - d8a8be1 linter/plugins: Avoid private methods (#14418) (overlookmotel) ### 🧪 Testing - d8da4a4 linter/plugins: Clarify tests for message placeholders (#14417) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Oct 5, 2025

This was referenced Oct 5, 2025

fix(tasks/lint_rules): update import syntax for eslint-plugin-react-hooks #14305

Merged

chore(tasks/lint_rules): unsupport more vue rules #14306

Merged

feat(linter): add vue/no-export-in-script-setup rule #14307

Merged

Sysix mentioned this pull request Oct 5, 2025

feat(linter): add vue/no-import-compiler-macros rule #14335

Merged

Sysix force-pushed the 10-05-feat_linter_add_vue_require-default-export_rule branch from 626733c to 57ed9a0 Compare October 5, 2025 12:49

graphite-app bot force-pushed the 10-04-feat_linter_add_vue_no-import-compiler-macros_rule branch 2 times, most recently from 07483be to 8d5b9c0 Compare October 6, 2025 08:27

Sysix force-pushed the 10-04-feat_linter_add_vue_no-import-compiler-macros_rule branch from 8d5b9c0 to 3ad8b15 Compare October 6, 2025 17:03

Sysix force-pushed the 10-05-feat_linter_add_vue_require-default-export_rule branch from 57ed9a0 to 2f673b2 Compare October 6, 2025 17:03

Sysix requested a review from Copilot October 6, 2025 17:05

Copilot AI reviewed Oct 6, 2025

View reviewed changes

crates/oxc_linter/src/rules/vue/require_default_export.rs Show resolved Hide resolved

crates/oxc_linter/src/rules/vue/require_default_export.rs Show resolved Hide resolved

Sysix marked this pull request as ready for review October 6, 2025 17:11

Sysix requested a review from camc314 as a code owner October 6, 2025 17:11

Sysix force-pushed the 10-05-feat_linter_add_vue_require-default-export_rule branch from 2f673b2 to ffc4c76 Compare October 6, 2025 19:10

Sysix force-pushed the 10-04-feat_linter_add_vue_no-import-compiler-macros_rule branch from 3ad8b15 to be46e43 Compare October 6, 2025 19:10

camc314 approved these changes Oct 7, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025

feat(linter): add vue/require-default-export rule (#14351)

83e7824

https://eslint.vuejs.org/rules/require-default-export related #11440

graphite-app bot force-pushed the 10-04-feat_linter_add_vue_no-import-compiler-macros_rule branch from be46e43 to ff98536 Compare October 7, 2025 16:04

graphite-app bot force-pushed the 10-05-feat_linter_add_vue_require-default-export_rule branch from ffc4c76 to 83e7824 Compare October 7, 2025 16:04

Base automatically changed from 10-04-feat_linter_add_vue_no-import-compiler-macros_rule to main October 7, 2025 16:08

graphite-app bot merged commit 83e7824 into main Oct 7, 2025
21 checks passed

graphite-app bot deleted the 10-05-feat_linter_add_vue_require-default-export_rule branch October 7, 2025 16:08

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025

Boshen mentioned this pull request Oct 8, 2025

release(oxlint): v1.21.0 #14439

Closed

Boshen mentioned this pull request Oct 8, 2025

release(oxlint): v1.21.0 #14441

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(linter): add `vue/require-default-export` rule #14351

feat(linter): add `vue/require-default-export` rule #14351

Sysix commented Oct 5, 2025 •

edited

Loading

Uh oh!

Sysix commented Oct 5, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 5, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 commented Oct 7, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(linter): add vue/require-default-export rule #14351

feat(linter): add vue/require-default-export rule #14351

Conversation

Sysix commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #14351 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Oct 7, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(linter): add `vue/require-default-export` rule #14351

feat(linter): add `vue/require-default-export` rule #14351

Sysix commented Oct 5, 2025 •

edited

Loading

Sysix commented Oct 5, 2025 •

edited

Loading

codspeed-hq bot commented Oct 5, 2025 •

edited

Loading

camc314 commented Oct 7, 2025 •

edited by graphite-app bot

Loading