Added pre-commit and license #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2024
jjaime2
reviewed
Dec 14, 2024
| "version": "4.21.5", | ||
| "resolved": "https://registry.npmjs.org/browserslist/-/browserslist-4.21.5.tgz", | ||
| "integrity": "sha512-tUkiguQGW7S3IhB7N+c2MV/HZPSCPAAiYBZXLsBhFB/PCy6ZKKsZrmBayHV9fdGV/ARIfJ14NkxKzRDjvp7L6w==", | ||
| "version": "4.24.2", |
There was a problem hiding this comment.
Are these automated version updates?
There was a problem hiding this comment.
I did them. Pre-commit was initially failing due to a versioning issue, which this addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pre-commit hooks for consistent formatting. It also adds a BSD 3-Clause License to this repository, and a license header on top of all Python, XML, YAML, JS(X), HTML, and CSS files. It also upgrades the versions of some packages to work better with pre-commit.
See
ada_feeding#206 for testing. Specifically, before merging any of these pre-commit/license PRs in, we ensured the entire feeding demo still works in bothrealandmock.Related PRs:
ada_feeding#206ada_ros2#51