removing the rest of the Polymorphic nodes from the AST tree #1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n`, and `TupleMember` from the AST tree
…rsionExpression`, and `VersionLiteral` from the AST tree
…erator`, and `YulSwitchCase` from the AST tree
fvictorio
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of the Polymorphic nodes have no edge cases.
The affected nodes are:
ForStatementConditionForStatementInitializationFunctionBodyFunctionNameImportClauseMappingKeyTypePragmaStringExpressionTupleMemberTypeNameUsingClauseUsingTargetVariableDeclarationTypeVersionExpressionVersionLiteralYulAssignmentOperatorYulExpressionYulLiteralYulStackAssignmentOperatorYulSwitchCasein this PR there is also a cleanup removing the
PolymorphicNodeclass andprintVariantfunction. since they are no longer needed.Also the type for the
genericPrintfunction signature is cleaned up as well