Skip to content

gh-142784: Make the asyncio REPL call .close() on the loop #142785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kumaraditya303 merged 10 commits into from
Dec 18, 2025
Merged

gh-142784: Make the asyncio REPL call .close() on the loop #142785

kumaraditya303 merged 10 commits into from
Dec 18, 2025
+4 −0

Conversation

@johnslavik
Copy link
Contributor

@johnslavik johnslavik commented Dec 16, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 16, 2025
Open
@johnslavik johnslavik mentioned this pull request Dec 16, 2025
Draft
@johnslavik
Copy link
Contributor Author

johnslavik commented Dec 16, 2025

I'm happy to have confirmed that this fixes the problem in GH-140288. I'll add a test and we're ready.

@johnslavik
Copy link
Contributor Author

johnslavik commented Dec 16, 2025

In the meantime -- @graingert, do you think this is the good direction?

@johnslavik johnslavik changed the title gh-142784: Employ asyncio.Runner in the asyncio REPL gh-142784: Make the asyncio REPL call .close() on the loop Dec 18, 2025
johnslavik
johnslavik commented Dec 18, 2025
View reviewed changes
@johnslavik johnslavik marked this pull request as ready for review December 18, 2025 12:01
@johnslavik
Copy link
Contributor Author

johnslavik commented Dec 18, 2025

@kumaraditya303 I've dropped asyncio.Runner and used .close() only, as discussed.

@johnslavik @kumaraditya303
Use a crossref to asyncio in the news entry
c5566ab 
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) December 18, 2025 12:31
@kumaraditya303 kumaraditya303 merged commit ddfc155 into python:main Dec 18, 2025
50 checks passed
@johnslavik
Copy link
Contributor Author

johnslavik commented Dec 18, 2025

@ZeroIntensity needs backport to 3.13 needs backport to 3.14

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 18, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 18, 2025

Thanks @johnslavik for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 18, 2025

Thanks @johnslavik for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 18, 2025
@johnslavik @miss-islington
pythongh-142784: make the asyncio REPL call loop.close() at exit (p…
d12868e 
…ythonGH-142785)

(cherry picked from commit ddfc155)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 18, 2025
@johnslavik @miss-islington
pythongh-142784: make the asyncio REPL call loop.close() at exit (p…
32ff6dc 
…ythonGH-142785)

(cherry picked from commit ddfc155)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 18, 2025

GH-142932 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 18, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 18, 2025

GH-142933 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 18, 2025
kumaraditya303 pushed a commit that referenced this pull request Dec 18, 2025
@miss-islington @johnslavik
[3.14] gh-142784: make the asyncio REPL call loop.close() at exit (G…
f02231b 
…H-142785) (#142933)

gh-142784: make the asyncio REPL call `loop.close()` at exit (GH-142785)
(cherry picked from commit ddfc155)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnslavik @kumaraditya303 @ZeroIntensity