-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-142784: Make the asyncio REPL call .close() on the loop
#142785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kumaraditya303
merged 10 commits into
python:main
from
johnslavik:asyncio-repl-close-loop
Dec 18, 2025
+4
−0
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
92f629b
Employ `asyncio.Runner` in the asyncio REPL
johnslavik 95cc73a
Add news entry
johnslavik ac134b1
Better wording in the news entry
johnslavik 9cbbf21
Revert "Employ `asyncio.Runner` in the asyncio REPL"
johnslavik 4639600
Call `.stop()` on the event loop when the asyncio REPL exits
johnslavik d3f670d
Add test to check asyncio REPL closes the loop
johnslavik 8b0824a
Better test name
johnslavik f5031b0
Move `loop.close()` below console log in present continuous tense
johnslavik 5e45253
Remove test
johnslavik c5566ab
Use a crossref to asyncio in the news entry
johnslavik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2025-12-16-04-39-27.gh-issue-142784.HBGJag.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| The asyncio REPL now properly closes the loop upon the end of interactive session. | ||
johnslavik marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| Previously, it could cause surprising warnings. | ||
| Contributed by Bartosz Sławecki. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.