Skip to content

[Backend Tester] Add permute, transpose, and masked_fill tests #12850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 29, 2025

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jul 25, 2025

Add tests for permute, transpose, and masked_fill.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12850

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 38 Pending

As of commit 831f814 with merge base 952fd1d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer GregoryComer marked this pull request as ready for review July 29, 2025 05:52
@GregoryComer GregoryComer requested a review from cccclai as a code owner July 29, 2025 05:52
@GregoryComer GregoryComer requested a review from digantdesai July 29, 2025 05:52

def test_permute_3d(self, flow: TestFlow) -> None:
self._test_op(
PermuteModel(dims=[2, 0, 1]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some test generator or Facto or even a meta class to generate permutations for permute might be better?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Should be easy to use itertools for this, I think. I'll take this as a follow-up.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/GregoryComer/96/head to main July 29, 2025 17:31
[ghstack-poisoned]
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jul 29, 2025
@GregoryComer GregoryComer merged commit 64d8223 into main Jul 29, 2025
100 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/97/head branch July 29, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants