[Backend Tester] Add SNR validation #12924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12924
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 93 PendingAs of commit 143fa15 with merge base 952fd1d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 28, 2025
digantdesai
reviewed
Jul 29, 2025
| rtol=rtol, | ||
| equal_nan=True, | ||
| ) | ||
| and computed_snr >= snr |
There was a problem hiding this comment.
Suggested change
| and computed_snr >= snr | |
| and (computed_snr >= snr | |
| or math.isnan(computed_snr)) |
digantdesai
approved these changes
Jul 29, 2025
GregoryComer
merged commit 15504dc
into
gh/GregoryComer/103/head
98 of 115 checks passed
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jul 31, 2025
Add SNR validation for model outputs. This is a generally more robust than tight element-wise tolerances, as it takes the entire tensor into account. I'm relaxing atol to handle outliers and reduce noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SNR validation for model outputs. This is a generally more robust than tight element-wise tolerances, as it takes the entire tensor into account. I'm relaxing atol to handle outliers and reduce noise.