[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Core #16474
+20
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the EXECUTORCH_CLIENTS buck client list that gates visibility on core infrastructure targets. This removes the gating rule in runtime_wrapper.bzl and replaces all visibility blocks containing @EXECUTORCH_CLIENTS with explicit PUBLIC visibility. This is part 1 of a multi-diff stack to remove visibility gating across all of executorch. This diff covers: - build/runtime_wrapper.bzl (removes the gating rule) - runtime/core/* targets - runtime/platform targets Differential Revision: [D89902032](https://our.internmc.facebook.com/intern/diff/D89902032/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16474
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit ffa8fa6 with merge base 09b5bdb ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This was referenced Jan 6, 2026
Merged
This PR needs a
|
JacobSzwejbka
approved these changes
Jan 6, 2026
… Core" Remove the EXECUTORCH_CLIENTS buck client list that gates visibility on core infrastructure targets. This removes the gating rule in runtime_wrapper.bzl and replaces all visibility blocks containing EXECUTORCH_CLIENTS with explicit PUBLIC visibility. This is part 1 of a multi-diff stack to remove visibility gating across all of executorch. This diff covers: - build/runtime_wrapper.bzl (removes the gating rule) - runtime/core/* targets - runtime/platform targets Differential Revision: [D89902032](https://our.internmc.facebook.com/intern/diff/D89902032/) [ghstack-poisoned]
meta-codesync
bot
merged commit 1af683a
into
gh/GregoryComer/167/base
165 of 166 checks passed
GregoryComer
added a commit
that referenced
this pull request
Jan 10, 2026
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #16474 by @GregoryComer ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/GregoryComer/167/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/GregoryComer/167/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/GregoryComer/167/orig Differential Revision: [D89902032](https://our.internmc.facebook.com/intern/diff/D89902032/) @diff-train-skip-merge Co-authored-by: Gregory Comer <gjcomer@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Remove the EXECUTORCH_CLIENTS buck client list that gates visibility on core infrastructure
targets. This removes the gating rule in runtime_wrapper.bzl and replaces all visibility
blocks containing @EXECUTORCH_CLIENTS with explicit PUBLIC visibility.
This is part 1 of a multi-diff stack to remove visibility gating across all of executorch.
This diff covers:
Differential Revision: D89902032