-
Notifications
You must be signed in to change notification settings - Fork 794
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Extensions #16479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/GregoryComer/172/base
Are you sure you want to change the base?
Conversation
Remove the EXECUTORCH_CLIENTS buck client list visibility gating from extension targets. This replaces all visibility blocks containing @EXECUTORCH_CLIENTS with explicit PUBLIC visibility. This is part 6 of a multi-diff stack to remove visibility gating across all of executorch. This diff covers all extension/*: - extension/android - extension/aten_util - extension/data_loader - extension/fb (dynamic_shim, ptez) - extension/flat_tensor - extension/kernel_util - extension/llm - extension/memory_allocator - extension/module - extension/pybindings - extension/tensor - extension/threadpool - extension/training Differential Revision: [D89902030](https://our.internmc.facebook.com/intern/diff/D89902030/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16479
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 13 PendingAs of commit 4d1edb2 with merge base 09b5bdb ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
… Extensions" Remove the EXECUTORCH_CLIENTS buck client list visibility gating from extension targets. This replaces all visibility blocks containing EXECUTORCH_CLIENTS with explicit PUBLIC visibility. This is part 6 of a multi-diff stack to remove visibility gating across all of executorch. This diff covers all extension/*: - extension/android - extension/aten_util - extension/data_loader - extension/fb (dynamic_shim, ptez) - extension/flat_tensor - extension/kernel_util - extension/llm - extension/memory_allocator - extension/module - extension/pybindings - extension/tensor - extension/threadpool - extension/training Differential Revision: [D89902030](https://our.internmc.facebook.com/intern/diff/D89902030/) [ghstack-poisoned]
Stack from ghstack (oldest at bottom):
Remove the EXECUTORCH_CLIENTS buck client list visibility gating from extension
targets. This replaces all visibility blocks containing @EXECUTORCH_CLIENTS
with explicit PUBLIC visibility.
This is part 6 of a multi-diff stack to remove visibility gating across all of executorch.
This diff covers all extension/*:
Differential Revision: D89902030