Skip to content

Conversation

albertomercurio
Copy link
Member

@albertomercurio albertomercurio commented Jul 23, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

The current implementation of the bloch_redfield_tensor function rotates the basis at the end. This is very inefficient as the rotation superoperator is a large dense matrix.

In this PR, I rotate the basis (if asked) directly during the computation. Avoiding to define the rotation operator. This surely improves the fock_basis=false case, and partially improves the true case.

@albertomercurio albertomercurio requested a review from ytdHuang July 23, 2025 05:53
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.08%. Comparing base (bc76e9f) to head (d565a3b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   94.05%   94.08%   +0.03%     
==========================================
  Files          51       51              
  Lines        3513     3533      +20     
==========================================
+ Hits         3304     3324      +20     
  Misses        209      209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albertomercurio albertomercurio requested a review from ytdHuang July 25, 2025 12:13
@albertomercurio albertomercurio requested a review from ytdHuang July 25, 2025 18:08
@albertomercurio albertomercurio merged commit 7a6cc50 into qutip:main Jul 26, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants