Skip to content

Improve efficiency of generation of Bloch-Redfield tensor and fix documentation typos #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 26, 2025
Merged

Improve efficiency of generation of Bloch-Redfield tensor and fix documentation typos #509

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
99b93ec
Update docs
albertomercurio Jul 23, 2025
0996550
Improve efficiency of bloch_redfield_tensor
albertomercurio Jul 23, 2025
f7543ea
Format code and add changelog
albertomercurio Jul 23, 2025
b1eb8bd
Allow Bool types in internal functioin
albertomercurio Jul 23, 2025
61461e8
Add auto_tidyup to avoid extra allocations
albertomercurio Jul 23, 2025
d8a280a
Minor changes
albertomercurio Jul 24, 2025
4517770
Update documentation on auto_tidyup
albertomercurio Jul 25, 2025
5e56876
Rotate operators in Hamiltonian space when possible
albertomercurio Jul 25, 2025
d565a3b
Better support to direct rotation in Hamiltonian space
albertomercurio Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/users_guide/settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Here, we list out each setting along with the specific functions that will use i

- `tidyup_tol::Float64 = 1e-14` : tolerance for [`tidyup`](@ref) and [`tidyup!`](@ref).
- `auto_tidyup::Bool = true` : Automatically tidyup during the following situations:
* Solving for eigenstates, including [`eigenstates`](@ref), [`eigsolve`](@ref), and [`eigsolve_al`](@ref).
* Solving for eigenstates, including [`eigenstates`](@ref), [`eigsolve`](@ref), [`eigsolve_al`](@ref), [`bloch_redfield_tensor`](@ref), [`brterm`](@ref) and [`brmesolve`](@ref).
- (to be announced)

## Change default settings
Expand Down
16 changes: 8 additions & 8 deletions src/time_evolution/brmesolve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function bloch_redfield_tensor(
U = QuantumObject(rst.vectors, Operator(), H.dimensions)
sec_cutoff = float(sec_cutoff)

H_new = getVal(fock_basis) ? H : QuantumObject(Diagonal(real.(rst.values)), Operator(), H.dimensions)
H_new = getVal(fock_basis) ? H : QuantumObject(Diagonal(rst.values), Operator(), H.dimensions)
c_ops_new = isnothing(c_ops) ? nothing : map(x -> getVal(fock_basis) ? x : U' * x * U, c_ops)
R = liouvillian(H_new, c_ops_new)

Expand Down Expand Up @@ -112,13 +112,6 @@ function _brterm(
ac_term = (A_mat .* spectrum) * A_mat
bd_term = A_mat * (A_mat .* trans(spectrum))

# Remove small values before passing in the Liouville space
if settings.auto_tidyup
tidyup!(A_mat)
tidyup!(ac_term)
tidyup!(bd_term)
end

if sec_cutoff != -1
m_cut = similar(skew)
map!(x -> abs(x) < sec_cutoff, m_cut, skew)
Expand All @@ -129,6 +122,13 @@ function _brterm(
M_cut = @. abs(vec_skew - vec_skew') < sec_cutoff
end

# Remove small values before passing in the Liouville space
if settings.auto_tidyup
tidyup!(A_mat)
tidyup!(ac_term)
tidyup!(bd_term)
end

out =
0.5 * (
+ _sprepost(A_mat .* trans(spectrum), A_mat) + _sprepost(A_mat, A_mat .* spectrum) - _spost(ac_term, Id) -
Expand Down
Loading