Automated Resyntax fixes #1441
Merged
Automated Resyntax fixes #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=80&v=4){kind=small}
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `match` expression can be simplified using `match-define`.
The `begin0` in this definition can be extracted into the surrounding definition context.
This `and` expression can be turned into a clause of the inner `match` expression, reducing nesting.
This expression is equivalent to calling the `positive?` predicate.
This use of `define-values` is unnecessary.
Use the `#:unless` keyword instead of `unless` to reduce loop body indentation.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
Using `cond` instead of `if` here makes `begin` unnecessary
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
This `let` expression can be pulled up into a `define` expression.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
This lambda function is equivalent to the built-in `positive?` predicate.
This `map` operation can be replaced with a `for/list` loop.
The `define` form supports a shorthand for defining functions.
This variable is returned immediately and can be inlined.
This `for/fold` loop can be simplified by using the `#:unless` keyword.
This `begin` form can be flattened into the surrounding definition context.
This negated `when` expression can be replaced by an `unless` expression.
This negated `unless` expression can be replaced by a `when` expression.
jackfirth
reviewed
Apr 6, 2025
| ;; Takes a possible substitution and computes | ||
| ;; the substituted range type if it is not #f | ||
| (define (finish substitution) | ||
| (begin0 |
There was a problem hiding this comment.
@samth This change was buggy. The define-begin0-extraction rule didn't account for when the surrounding define is a function definition instead of a variable definition.
There was a problem hiding this comment.
Fixed in jackfirth/resyntax#445.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 50 issues in 17 files.
let-to-definesingle-clause-match-to-match-definedefine-lambda-to-defineif-begin-to-condzero-comparison-to-positive?if-let-to-conddefine-values-values-to-defineinline-unnecessary-definealways-throwing-cond-to-whenfor/fold-with-conditional-body-to-unless-keywordzero-comparison-lambda-to-positive?inverted-unlesswhen-expression-in-for-loop-to-when-keyworddefine-let-to-double-definedefine-begin0-extractioninverted-whenmap-to-forunless-expression-in-for-loop-to-unless-keywordand-match-to-matchinline-unnecessary-begin