Skip to content

Automated Resyntax fixes #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 4, 2025
Merged

Automated Resyntax fixes #1441

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b4b1a3a
Fix 10 occurrences of `let-to-define`
resyntax-ci[bot] Mar 7, 2025
478293e
Fix 8 occurrences of `single-clause-match-to-match-define`
resyntax-ci[bot] Mar 7, 2025
569e226
Fix 1 occurrence of `define-begin0-extraction`
resyntax-ci[bot] Mar 7, 2025
715a8d1
Fix 1 occurrence of `and-match-to-match`
resyntax-ci[bot] Mar 7, 2025
76206de
Fix 3 occurrences of `zero-comparison-to-positive?`
resyntax-ci[bot] Mar 7, 2025
9b0f222
Fix 3 occurrences of `define-values-values-to-define`
resyntax-ci[bot] Mar 7, 2025
9931b81
Fix 1 occurrence of `unless-expression-in-for-loop-to-unless-keyword`
resyntax-ci[bot] Mar 7, 2025
f006b00
Fix 1 occurrence of `when-expression-in-for-loop-to-when-keyword`
resyntax-ci[bot] Mar 7, 2025
74f311c
Fix 4 occurrences of `if-begin-to-cond`
resyntax-ci[bot] Mar 7, 2025
1c29459
Fix 3 occurrences of `if-let-to-cond`
resyntax-ci[bot] Mar 7, 2025
cc314a9
Fix 1 occurrence of `define-let-to-double-define`
resyntax-ci[bot] Mar 7, 2025
73b873b
Fix 1 occurrence of `always-throwing-cond-to-when`
resyntax-ci[bot] Mar 7, 2025
59f77fd
Fix 1 occurrence of `zero-comparison-lambda-to-positive?`
resyntax-ci[bot] Mar 7, 2025
faa6a61
Fix 1 occurrence of `map-to-for`
resyntax-ci[bot] Mar 7, 2025
998b89b
Fix 5 occurrences of `define-lambda-to-define`
resyntax-ci[bot] Mar 7, 2025
506cef5
Fix 2 occurrences of `inline-unnecessary-define`
resyntax-ci[bot] Mar 7, 2025
16d4445
Fix 1 occurrence of `for/fold-with-conditional-body-to-unless-keyword`
resyntax-ci[bot] Mar 7, 2025
7f45b20
Fix 1 occurrence of `inline-unnecessary-begin`
resyntax-ci[bot] Mar 7, 2025
32d2a82
Fix 1 occurrence of `inverted-when`
resyntax-ci[bot] Mar 7, 2025
eb5463d
Fix 1 occurrence of `inverted-unless`
resyntax-ci[bot] Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions typed-racket-lib/typed-racket/typecheck/tc-apply.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,8 @@
;; Takes a possible substitution and computes
;; the substituted range type if it is not #f
(define (finish substitution)
(begin0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samth This change was buggy. The define-begin0-extraction rule didn't account for when the surrounding define is a function definition instead of a variable definition.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in jackfirth/resyntax#445.

(and substitution (do-ret (subst-all substitution rng)))
(add-typeof-expr f (ret (make-Fun (list arrow))))))
(and substitution (do-ret (subst-all substitution rng))))
(add-typeof-expr f (ret (make-Fun (list arrow))))
(finish
(infer vars dotted-vars
(list (-Tuple* arg-tys full-tail-ty))
Expand Down