fix(orchestrator): Disable Next button when active widgets are fetching and processing data #1672
Conversation
lokanandaprabhu
requested review from
batzionb,
gciavarrini and
mareklibra
as code owners
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
|
| setAuthTokenDescriptors: ( | ||
| authTokenDescriptors: AuthTokenDescriptor[], | ||
| ) => void; | ||
| handleFetchStarted?: () => void; |
There was a problem hiding this comment.
Is there a need to have those as optional?
| }, [formApi]); | ||
|
|
||
| return <NewComponent {...props} />; | ||
| const propsWithFetchHandlers = useMemo( |
There was a problem hiding this comment.
Can this be left to the FormComponent? Similar to the handleValidate* hooks.
|
|
||
| setLabels(selectedLabels); | ||
| setValues(selectedValues); | ||
| await wrapProcessing(async () => { |
There was a problem hiding this comment.
Why is that? Isn't tracking of the fetch enough?
These applySelector* are just sort of filtering the already loaded data
| * @param handleFetchEnded - Optional callback to notify when processing ends | ||
| * @returns Object containing processing state management | ||
| */ | ||
| export const useProcessingState = ( |
There was a problem hiding this comment.
I am not sure we need this additional hook. All the data is in the form context, including isFecthing
2 participants
Hey, I just made a Pull Request!
Story:
https://issues.redhat.com/browse/FLPATH-2770
Disable Next button when active widgets are fetching and processing data
✔️ Checklist