Skip to content

Conversation

@calebbourg
Copy link
Collaborator

@calebbourg calebbourg commented Apr 5, 2025

Description

This PR wires up the plumbing for deleting Coaching Sesssions

The following applies:

  • Only users that are coaches for the coaching session are authorized to delete it
  • We attempt to delete the associated Tiptap document. If that fails we do not delete the coaching session

Changes

  • Updates CoachingSession component dropdown to trigger Coaching Session deletion and refresh

@calebbourg calebbourg changed the base branch from main to update_coaching_sessions April 5, 2025 13:24
@calebbourg calebbourg self-assigned this Apr 5, 2025
@calebbourg calebbourg added the feature work Specifically implementing a new feature label Apr 5, 2025
@calebbourg calebbourg added this to the 1.0-beta1 milestone Apr 5, 2025
@calebbourg calebbourg requested review from jhodapp and zgavin1 April 5, 2025 13:25
<DropdownMenuItem className="text-destructive">
Delete Session
</DropdownMenuItem>
{isCoach && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isCoach is working out so well, I love it.

</DropdownMenuItem>
{isCoach && (
<DropdownMenuItem onClick={onDelete} className="text-destructive">
Delete Session
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned in my other review in PR #96, change this text to "Delete".

@jhodapp jhodapp merged commit a17885a into update_coaching_sessions Apr 5, 2025
4 checks passed
@jhodapp jhodapp deleted the delete_coaching_sessions branch April 5, 2025 20:22
@github-project-automation github-project-automation bot moved this from Review to ✅ Done in Refactor Coaching Platform Apr 5, 2025
@jhodapp
Copy link
Member

jhodapp commented Apr 5, 2025

I approved and went ahead and merged this into your parent branch, @calebbourg. I want to start on the coaching session list changes on the Dashboard page, and will branch off of your update_coaching_sessions combined branch for this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature work Specifically implementing a new feature

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants