Delete coaching sessions #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhodapp
requested changes
Apr 5, 2025
Member
jhodapp
left a comment
jhodapp
left a comment
There was a problem hiding this comment.
Looks fantastic! One minor suggested change to make.
domain/src/gateway/tiptap.rs
Outdated
| } | ||
|
|
||
| pub async fn create(&self, document_name: &str) -> Result<(), Error> { | ||
| let url = format!( |
Member
There was a problem hiding this comment.
I suggest pulling this up to the top of this module since it's repeated for create and delete, which will also help centralize it in case TipTap ever changes their cloud API paths.
calebbourg
force-pushed
the
delete_coaching_sessions
branch
from
3e0a566 to
961d084
Compare
jhodapp
approved these changes
Apr 9, 2025
github-project-automation
bot
moved this from Review
to ✅ Done
in Refactor Coaching Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds endpoint for deleting existing coaching sessions.
The following applies:
Changes
domain::coaching_sessionsTesting Strategy
Tested locally against refactor-group/refactor-platform-fe#100