Add a middleware layer, handle optimistic auth check on basic routes #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhodapp
requested changes
Mar 12, 2025
Member
jhodapp
left a comment
jhodapp
left a comment
There was a problem hiding this comment.
Looks great Zach, thank you. A few things line to have a look at.
Contributor
Author
|
Clicking around a bit more than I did earlier. This might be a little premature. Reverting to draft for now |
Co-authored-by: Jim Hodapp <james.hodapp@gmail.com>
…h-store from localStorage
zgavin1
force-pushed
the
optimistic_nextjs_middleware_auth_check
branch
from
ec7284f to
466e086
Compare
…er initiatlization
jhodapp
approved these changes
Mar 15, 2025
Member
jhodapp
left a comment
jhodapp
left a comment
There was a problem hiding this comment.
Looks great, works as expected.
There is a newly exposed bug from moving to localStorage where the coaching_session_id contained in the URL vs the one in the AuthStore are used differently on the coaching session page and becomes evident when you try and open the same coaching session URL on a new tab of the same browser. But this isn't your fault, it's just a bug outside the scope of this PR.
github-project-automation
bot
moved this from Review
to ✅ Done
in Refactor Coaching Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NextJS has a cool middleware feature we can leverage.
If I'm logged in and try to visit the login index page, redirect me to the dashboard. If I'm logged out and I try to access /dashboard or /coaching-session/... route, redirect me to the login index page.
This is not meant to be an all-encompassing route protection system. Just a simple "optimistic' light weight check against the cookie set by our login/logout API.
This does log a user out if their session expires from the backend.
Screenshots / Videos Showing UI Changes (if applicable)
Testing Strategy
describe how you or someone else can test and verify the changes
Concerns
Exposes bug #79 by the use of localStorage but not responsible for the bug.