-
Notifications
You must be signed in to change notification settings - Fork 2
Add a middleware layer, handle optimistic auth check on basic routes #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e0fdf0b
Add a middleware layer, handle optimistic auth check on basic routes
zgavin1 105ec9f
fix variable declaration src/middleware.ts
zgavin1 acd057c
Adjust middleware approach, using localstorage and reinitializing aut…
zgavin1 a148ed0
Remove comment
zgavin1 37109a1
fix lint error
zgavin1 466e086
remove window reference
zgavin1 fee8f3a
Add check for window before accessing localstorage in authstoreprovid…
zgavin1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { NextRequest, NextResponse } from "next/server"; | ||
|
|
||
| // 1. Specify protected and public routes | ||
| const protectedRoutes = [ | ||
| "/dashboard", | ||
| "/coaching-sessions", | ||
| "/settings", | ||
| "/profile", | ||
| ]; | ||
| const publicRoutes = ["/"]; | ||
|
|
||
| export default async function middleware(req: NextRequest) { | ||
| // 2. Check if the current route is protected or public | ||
| const path = req.nextUrl.pathname; | ||
| const isProtectedRoute = protectedRoutes.some((route) => | ||
| path.startsWith(route) | ||
| ); | ||
| const isPublicRoute = publicRoutes.some((route) => path === route); | ||
|
|
||
| // 3. Get the session from the cookie | ||
| const sessionCookie = req.cookies.get("id"); | ||
| const session = sessionCookie?.value; | ||
|
|
||
| // 4. Redirect to / if the user is not authenticated | ||
| // 4b. TODO: Check session validity/expiration? | ||
| if (isProtectedRoute && !session) { | ||
| return NextResponse.redirect(new URL("/", req.nextUrl)); | ||
| } | ||
|
|
||
| // 5. Redirect to /dashboard if the user is authenticated | ||
jhodapp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if ( | ||
| isPublicRoute && | ||
| session && | ||
| !req.nextUrl.pathname.startsWith("/dashboard") | ||
| ) { | ||
| return NextResponse.redirect(new URL("/dashboard", req.nextUrl)); | ||
| } | ||
|
|
||
| return NextResponse.next(); | ||
| } | ||
|
|
||
| // Routes Middleware should not run on | ||
| export const config = { | ||
| matcher: ["/((?!api|_next/static|_next/image|favicon.ico|.*\\.png$).*)"], | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.