Skip to content

Conversation

@calebbourg
Copy link
Collaborator

@calebbourg calebbourg commented Apr 1, 2025

Description

This PR adds the ability for a Coach to delete a Coachee.

Constraints:

  • The current user can only delete other users that are direct Coachees
  • The current user cannot delete themself

Changes

  • Adds delete button to members page

Screenshots / Videos Showing UI Changes (if applicable)

Screenshot 2025-04-01 at 10 05 44

Testing Strategy

Concerns

describe any concerns that might be worth mentioning or discussing

@calebbourg calebbourg self-assigned this Apr 1, 2025
@calebbourg calebbourg added the feature work Specifically implementing a new feature label Apr 1, 2025
@jhodapp jhodapp moved this to 🏗 In progress in Refactor Coaching Platform Apr 1, 2025
@jhodapp jhodapp moved this from 🏗 In progress to Review in Refactor Coaching Platform Apr 1, 2025
@jhodapp jhodapp added this to the 1.0-beta1 milestone Apr 1, 2025
Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, works well. Some minor inline changes and I'll be happy to approve.

@jhodapp
Copy link
Member

jhodapp commented Apr 1, 2025

@calebbourg reminder as discussed in Slack: The Member page has 2 titles and only needs one on that page, and it should be an <h3> element. Would you mind making that update in this PR too since it’s such a minor change? Make sure it matches the title in style on the Dashboard page.

@calebbourg
Copy link
Collaborator Author

@jhodapp Thank you for the review! I think I've addressed everything. Including removing the extra title on the members page

Screenshot 2025-04-02 at 6 18 48 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calebbourg The "Add Member" button is now on the left side of the screen instead of the right, which it should be on the right to be consistent with other pages.

@calebbourg calebbourg force-pushed the 88-feature-add-member-management-page-delete-users branch from accebcf to dfa4cb3 Compare April 4, 2025 10:48
@calebbourg
Copy link
Collaborator Author

@jhodapp How does this look dfa4cb3
Screenshot 2025-04-04 at 6 47 53 AM

@jhodapp
Copy link
Member

jhodapp commented Apr 4, 2025

@jhodapp How does this look dfa4cb3 Screenshot 2025-04-04 at 6 47 53 AM

@calebbourg Looks great, are you sure this is the right commit? It's from 2 days ago, I don't see a pushed commit that changes the button to be right justified.

@calebbourg
Copy link
Collaborator Author

@jhodapp I believe it is. I moved the "Members" text into the actual component and it placed the button to that side. I chose that approach to couple the both the text and the button with the list itself. Let me know what you think about that.

@jhodapp
Copy link
Member

jhodapp commented Apr 4, 2025

@jhodapp I believe it is. I moved the "Members" text into the actual component and it placed the button to that side. I chose that approach to couple the both the text and the button with the list itself. Let me know what you think about that.

I think that's a fine approach for our needs right now on the page, and we an change it in the future easily if necessary.

@calebbourg calebbourg merged commit b049bf4 into main Apr 4, 2025
4 checks passed
@calebbourg calebbourg deleted the 88-feature-add-member-management-page-delete-users branch April 4, 2025 17:13
@github-project-automation github-project-automation bot moved this from Review to ✅ Done in Refactor Coaching Platform Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature work Specifically implementing a new feature

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants