-
Notifications
You must be signed in to change notification settings - Fork 2
Add Delete User #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Delete User #95
Conversation
jhodapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, works well. Some minor inline changes and I'll be happy to approve.
|
@calebbourg reminder as discussed in Slack: The Member page has 2 titles and only needs one on that page, and it should be an |
|
@jhodapp Thank you for the review! I think I've addressed everything. Including removing the extra title on the members page
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calebbourg The "Add Member" button is now on the left side of the screen instead of the right, which it should be on the right to be consistent with other pages.
accebcf to
dfa4cb3
Compare
|
@calebbourg Looks great, are you sure this is the right commit? It's from 2 days ago, I don't see a pushed commit that changes the button to be right justified. |
|
@jhodapp I believe it is. I moved the "Members" text into the actual component and it placed the button to that side. I chose that approach to couple the both the text and the button with the list itself. Let me know what you think about that. |
I think that's a fine approach for our needs right now on the page, and we an change it in the future easily if necessary. |



Description
This PR adds the ability for a Coach to delete a Coachee.
Constraints:
Changes
Screenshots / Videos Showing UI Changes (if applicable)
Testing Strategy
Concerns
describe any concerns that might be worth mentioning or discussing