make specialization of Vec::extend and VecDeque::extend_front work for vec::IntoIter with any Allocator, not just Global
#150597
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r vec::IntoIter with any Allocator, not just Global
rustbot
added
S-waiting-on-review
Collaborator
Member
|
@bors r+ rollup=iffy |
Collaborator
bors
added
S-waiting-on-bors
9 tasks
bors
added a commit
that referenced
this pull request
Jan 4, 2026
Rollup of 5 pull requests Successful merges: - #150554 (test: add regression cases for valtree hashing ICE) - #150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - #150619 (alloc: Move Cow impl to existing ones) - #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - #150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jan 4, 2026
Rollup merge of #150597 - antonilol:extend-from-vec-any-allocator, r=jhpratt make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global` These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`. (extra context: `VecDeque::extend_front` is unstable and tracked by #146975)
Collaborator
Member
|
@bors r- |
bors
added
S-waiting-on-author
Member
|
bors is currently testing multiple PRs, more than one of which are merged @ EDIT: edited to prevent bors from picking up command in a future sync |
Member
|
@bors retry r- (sync) |
Member
|
EDIT: edited to prevent bors from picking up command in a future sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions consume all the elements from the respective collection, but do not care about the
Allocatorthey use. Without specifying one (like invec::IntoIter<T>) the specialization is only chosen whenA=Global.(extra context:
VecDeque::extend_frontis unstable and tracked by #146975)