Add test for changing backup method #4575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds TestRestoreFullChangingMethodIntegration, which verifies that changing backup method from rclone to native and so forth results in a correct restore. It also removes new task ID generation on every backup/restore run, as it shouldn't be needed and prevents from verifying retention policy behavior.
Michal-Leszczynski
force-pushed
the
ml/native-method-tests
branch
from
858a8b9 to
7422ad8
Compare
Michal-Leszczynski
requested review from
VAveryanov8 and
karol-kokoszka
as code owners
|
@karol-kokoszka @VAveryanov8 this PR is ready for review! |
2 similar comments
|
@karol-kokoszka @VAveryanov8 this PR is ready for review! |
|
@karol-kokoszka @VAveryanov8 this PR is ready for review! |
VAveryanov8
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds TestRestoreFullChangingMethodIntegration, which verifies that changing backup method from rclone to native and so forth results in a correct restore.
It also removes new task ID generation on every backup/restore run, as it shouldn't be needed and prevents from verifying retention policy behavior.
Refs https://github.com/scylladb/siren/issues/14212