Skip to content

Add default request for ephemeral storage in helm chart #7640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add default request for ephemeral storage in helm chart #7640

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e889201
add request for ephemeral storage in helm chart
SeungjinYang Oct 16, 2025
a2f1392
comment on helm chart
SeungjinYang Oct 16, 2025
58663df
requests only
SeungjinYang Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/skypilot/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ apiService:
requests:
cpu: "4"
memory: "8Gi"
# not much ephemeral-storage is needed when
# persistent storage is enabled.
# However, when ephemeral storage is used
# (e.g. to enable rollingUpdate),
# it is recommended to set a larger value.
ephemeral-storage: "10Gi"
Copy link
Collaborator

@DanielZhangQD DanielZhangQD Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need ephemeral-storage when PVC is enabled? If not, we should not enable it by default here. Maybe we can add a field in storage to indicate persistent or ephemeral storage?

limits:
cpu: "4"
memory: "8Gi"
Expand Down