-
Notifications
You must be signed in to change notification settings - Fork 16
feat: support adding words to dictionary with a callback #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: support adding words to dictionary with a callback #95
Conversation
style: move all constants to class static members
ui: use default icon button padding export result to allow custom language check service implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @andrew-bekhiet-solid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the spell-checking capabilities by allowing users to maintain a personal dictionary. This feature enables the system to learn and ignore specific words, such as proper nouns or domain-specific terminology, thereby improving the precision and user experience of the spell checker. The changes involve new service implementations, controller updates, and UI adjustments to support this functionality.
Highlights
- Custom Dictionary Support: Introduced the ability to add words to a custom dictionary directly from the mistake popup, enhancing spell-checking accuracy and reducing false positives.
- In-Memory Dictionary Service: Implemented a new
InMemoryDictionaryLanguageCheckServicethat filters spell-check suggestions based on a user-defined, dynamic dictionary. - Text Re-evaluation: Added a
recheckTextmethod toLanguageToolControllerto explicitly re-evaluate the text for mistakes, useful after dictionary updates or configuration changes. - Mistake Popup Enhancements: Improved the
LanguageToolMistakePopupby adding an 'add to dictionary' action and refining its visual layout with adjusted icon sizes and padding. - Example Application Update: The example application now includes a UI for managing the in-memory dictionary, demonstrating the new functionality.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a great new feature for adding words to a custom dictionary, which will be very useful. The implementation is solid, with a new InMemoryDictionaryLanguageCheckService and UI hooks in the mistake popup. I've provided a few suggestions to improve robustness and flexibility, mainly around error handling for the dictionary callback and making the new service more composable. The example app has also been updated well to showcase the feature, though I have a minor suggestion to prevent potential UI overflows.
lib/src/wrappers/in_memory_dictionary_language_check_service.dart
Outdated
Show resolved
Hide resolved
|
Thanks @andrew-bekhiet-solid - could you please also add a screenshot? I'm assuming that should be some UI button with it. |


No description provided.