Skip to content

Conversation

@tembleking
Copy link
Member

No description provided.

Co-Authored-By: Alejandro Magallón Soler <alejandro.magallon@sysdig.com>
@tembleking tembleking self-assigned this Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 09:39
@tembleking tembleking requested a review from a team as a code owner December 9, 2025 09:39
@tembleking tembleking enabled auto-merge (squash) December 9, 2025 09:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for skipping TLS verification when connecting to the Sysdig API, useful for environments with self-signed certificates (e.g., on-premises deployments). The implementation introduces a new configuration option controlled via the SYSDIG_MCP_API_SKIP_TLS_VERIFICATION environment variable.

Key changes:

  • Added SkipTLSVerification boolean configuration field with environment variable support
  • Refactored client initialization to support both RequestEditorFn and ClientOption types through a new IntoClientOption interface
  • Added comprehensive test coverage for TLS verification behavior and invalid boolean environment variable handling

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.nix Version bump from 0.5.4 to 0.6.0
go.mod Go version update from 1.25.2 to 1.25.5
internal/config/config.go Added SkipTLSVerification field and made getEnv generic to handle boolean parsing
internal/config/config_test.go Added test cases for the new TLS verification configuration
internal/infra/sysdig/client.go Introduced IntoClientOption interface to support mixed option types
internal/infra/sysdig/client_test.go Added TLS verification tests with self-signed certificate scenarios
cmd/server/main.go Implemented custom HTTP client with InsecureSkipVerify when configured
README.md Documented the new SYSDIG_MCP_API_SKIP_TLS_VERIFICATION environment variable
docs/TROUBLESHOOTING.md Added troubleshooting entry for certificate authority errors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mateobur
mateobur previously approved these changes Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 09:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tembleking tembleking force-pushed the feat/add-support-for-skip-tls-verification branch from 0c7fce9 to d415cd9 Compare December 9, 2025 09:44
@tembleking tembleking force-pushed the feat/add-support-for-skip-tls-verification branch from d415cd9 to 39ee402 Compare December 9, 2025 10:15
Copilot AI review requested due to automatic review settings December 9, 2025 10:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tembleking tembleking disabled auto-merge December 9, 2025 10:55
@tembleking tembleking merged commit ff69330 into main Dec 9, 2025
4 of 5 checks passed
@tembleking tembleking deleted the feat/add-support-for-skip-tls-verification branch December 9, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants