-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add support for skip TLS verification #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| package sysdig_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "crypto/tls" | ||
| "log" | ||
| "net/http" | ||
| "net/http/httptest" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| "github.com/sysdiglabs/sysdig-mcp-server/internal/infra/sysdig" | ||
| ) | ||
|
|
||
| var _ = Describe("Client TLS", func() { | ||
| var ts *httptest.Server | ||
|
|
||
| BeforeEach(func() { | ||
| // Start a TLS server with a self-signed certificate | ||
| ts = httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if r.URL.Path == "/api/users/me/permissions" { | ||
| w.Header().Set("Content-Type", "application/json") | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte(`{"permissions":[]}`)) | ||
| return | ||
| } | ||
| w.WriteHeader(http.StatusNotFound) | ||
| })) | ||
| // Redirect server logs to GinkgoWriter to avoid noise in test output | ||
| ts.Config.ErrorLog = log.New(GinkgoWriter, "", 0) | ||
| }) | ||
|
|
||
| AfterEach(func() { | ||
| ts.Close() | ||
| }) | ||
|
|
||
| It("should fail request with self-signed cert by default", func() { | ||
| // Create client pointing to the TLS server without custom transport | ||
| client, err := sysdig.NewSysdigClient( | ||
| sysdig.WithFixedHostAndToken(ts.URL, "dummy-token"), | ||
| ) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| // Attempt request | ||
| _, err = client.GetMyPermissionsWithResponse(context.Background()) | ||
| Expect(err).To(HaveOccurred()) | ||
| // Verification that it failed due to certificate issues | ||
| Expect(err.Error()).To(Or(ContainSubstring("certificate"), ContainSubstring("unknown authority"))) | ||
| }) | ||
|
|
||
| It("should succeed request when using custom HTTP client with InsecureSkipVerify", func() { | ||
| // Create custom HTTP client that skips verification | ||
| transport := http.DefaultTransport.(*http.Transport).Clone() | ||
| transport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} | ||
| httpClient := &http.Client{Transport: transport} | ||
|
|
||
| // Create client using the custom HTTP client | ||
| client, err := sysdig.NewSysdigClient( | ||
| sysdig.WithFixedHostAndToken(ts.URL, "dummy-token"), | ||
| sysdig.WithHTTPClient(httpClient), | ||
| ) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| // Attempt request | ||
| resp, err := client.GetMyPermissionsWithResponse(context.Background()) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(resp.HTTPResponse.StatusCode).To(Equal(http.StatusOK)) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.