fix: Set logConfiguration to null if empty to prevent ECS errors #323
Conversation
| @@ -47,7 +47,7 @@ locals { | |||
| interactive = var.interactive | |||
| links = local.is_not_windows ? var.links : null | |||
| linuxParameters = local.is_not_windows ? { for k, v in local.linuxParameters : k => v if v != null } : null | |||
| logConfiguration = local.logConfiguration | |||
| logConfiguration = length(local.logConfiguration) > 0 ? local.logConfiguration : null | |||
There was a problem hiding this comment.
this does not match what is described in the title - we'll need a reproduction or proof of this working as intended
There was a problem hiding this comment.
this does not match what is described in the title
Which parts specifically do not match?
The details of the error and how to deal with it are as follows.
If create_cloudwatch_log_group is set to false, local.logConfiguration will be an empty object. As a result, the required field logConfiguration.logDriver is not filled in and an error occurs.
This response avoids the error by checking the number of elements in local.logConfiguration and returning null if it is an empty object.
This error is the same as the error fixed in #91.
The problem solved in #91 has reoccurred due to the response in #217.
I think this PR will solve #318.
Description
Set logConfiguration to null if empty to prevent ECS errors.
fix #318
ref #91 #217
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request