Skip to content

fix: Set logConfiguration to null if empty to prevent ECS errors #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025
Merged

fix: Set logConfiguration to null if empty to prevent ECS errors #323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3beedb4
fix: Set logConfiguration to null if empty to prevent ECS errors
mo36924 Jul 22, 2025
b030d43
Merge branch 'master' into fix/318
bryantbiggs Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/container-definition/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ locals {
interactive = var.interactive
links = local.is_not_windows ? var.links : null
linuxParameters = local.is_not_windows ? { for k, v in local.linuxParameters : k => v if v != null } : null
logConfiguration = local.logConfiguration
logConfiguration = length(local.logConfiguration) > 0 ? local.logConfiguration : null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not match what is described in the title - we'll need a reproduction or proof of this working as intended

Copy link
Contributor Author

@mo36924 mo36924 Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not match what is described in the title

Which parts specifically do not match?

The details of the error and how to deal with it are as follows.
If create_cloudwatch_log_group is set to false, local.logConfiguration will be an empty object. As a result, the required field logConfiguration.logDriver is not filled in and an error occurs.
This response avoids the error by checking the number of elements in local.logConfiguration and returning null if it is an empty object.

This error is the same as the error fixed in #91.
The problem solved in #91 has reoccurred due to the response in #217.
I think this PR will solve #318.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into the same error mentioned in #318 and was able to validate that the changes in this PR fixes the issue 👍.

memory = var.memory
memoryReservation = var.memoryReservation
mountPoints = var.mountPoints
Expand Down