audio: copier: Fix memory corruption with TRANS_GAIN with gcc #10336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujfalusi
requested review from
RanderWang,
abonislawski and
pblaszko
as code owners
kv2019i
approved these changes
Oct 28, 2025
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
A "fixes: xxx" would be useful but not manadatory for FW commits.
The dst pointer must not be used directly while applying TRANS_GAIN to avoid corrupting memory in heap. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Fixes: 6993617 ("copier: gain: add processing functions") Closes: thesofproject#10318
ujfalusi
force-pushed
the
peter/pr/gain-with-gcc-fix
branch
from
9e4e3aa to
130464f
Compare
Contributor
Author
|
Changes since v1:
|
abonislawski
approved these changes
Oct 29, 2025
lyakh
approved these changes
Oct 29, 2025
singalsu
approved these changes
Oct 29, 2025
tmleman
approved these changes
Oct 29, 2025
lgirdwood
approved these changes
Oct 29, 2025
Member
|
@lrudyX good to merge, passing on other CIs. |
Failed at one test, scheduled for rerun |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
he dst pointer must not be used directly while applying TRANS_GAIN to
avoid corrupting memory in heap.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com
Fixes: 6993617 ("copier: gain: add processing functions")
Closes: #10318