Skip to content

audio: copier: Fix memory corruption with TRANS_GAIN with gcc #10336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Oct 30, 2025
Merged

audio: copier: Fix memory corruption with TRANS_GAIN with gcc #10336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/audio/copier/copier_generic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ int copier_gain_input16(struct comp_buffer *buff, enum copier_gain_state state,

/* Apply fade */
for (j = 0; j < nch; j++) {
dst += j;
dst_tmp = dst + j;
/* Quadratic fade part in Q15 format*/
gain_env_sq = q_multsr_16x16(gain_env[j], gain_env[j], 15);

Expand All @@ -180,8 +180,8 @@ int copier_gain_input16(struct comp_buffer *buff, enum copier_gain_state state,
gain_env_sq, 15);

for (i = 0; i < nmax; i += nch)
dst[i] = q_multsr_sat_16x16(dst[i], gain,
GAIN_Q10_INT_SHIFT);
dst_tmp[i] = q_multsr_sat_16x16(dst_tmp[i], gain,
GAIN_Q10_INT_SHIFT);
}
samples -= nmax;
dst = audio_stream_wrap(&buff->stream, dst + nmax);
Expand Down Expand Up @@ -260,7 +260,7 @@ int copier_gain_input32(struct comp_buffer *buff, enum copier_gain_state state,

/* Apply fade */
for (j = 0; j < nch; j++) {
dst += j;
dst_tmp = dst + j;
/* Quadratic fade part in Q15 format*/
gain_env_sq = q_multsr_16x16(gain_env[j], gain_env[j], 15);

Expand All @@ -271,8 +271,8 @@ int copier_gain_input32(struct comp_buffer *buff, enum copier_gain_state state,
gain_env_sq, 15);

for (i = 0; i < nmax; i += nch)
dst[i] = q_multsr_sat_32x32(dst[i], gain,
GAIN_Q10_INT_SHIFT);
dst_tmp[i] = q_multsr_sat_32x32(dst_tmp[i], gain,
GAIN_Q10_INT_SHIFT);
}
samples -= nmax;
dst = audio_stream_wrap(&buff->stream, dst + nmax);
Expand Down
Loading