audio: volume: drop CONFIG_COMP_PEAK_VOL guards #9960
Merged
+0
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentiuM1234
force-pushed
the
fix/volume_ifdef_guards
branch
2 times, most recently
from
f1ea453 to
45d0941
Compare
LaurentiuM1234
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
dbaluta
approved these changes
Apr 7, 2025
Commit fcfcb07 ("llext: remove unneeded data and functions") introduced some "ifdef" guards that make the volume component unusable unless "CONFIG_COMP_GAIN" or "CONFIG_COMP_PEAK_VOL" is enabled. This change in behavior results in the following error on the firmware side: <ERROR_MSG> <err> ipc: get_drv(): the provided UUID (b77e677e41885ff4a8fb14af8286bfbd) doesn't match to any driver! </ERROR_MSG> for an i.MX platform using the volume component with "CONFIG_COMP_GAIN=n" and "CONFIG_COMP_PEAK_VOL=n". Based on the Kconfig description, "CONFIG_COMP_GAIN" refers to the gain component, while "CONFIG_COMP_PEAK_VOL" refers to (snippet taken from the volume Kconfig): "This option enables reporting to host peak vol regs.". This description implies that "CONFIG_COMP_PEAK_VOL" doesn't manage the component itself. This is further reinforced by the fact that, previously, using the peak volume component without the "CONFIG_COMP_PEAK_VOL" config enabled worked fine. As such, drop all of the "CONFIG_COMP_PEAK_VOL" "ifdef" guards that were introduced by the aforementioned commit. Fixes fcfcb07 ("llext: remove unneeded data and functions") Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
iuliana-prodan
approved these changes
Apr 7, 2025
Member
|
@singalsu pls review |
singalsu
approved these changes
Apr 7, 2025
Collaborator
|
Works OK here, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fcfcb07 ("llext: remove unneeded data and functions")
introduced some "ifdef" guards that make the volume component unusable
unless "CONFIG_COMP_GAIN" or "CONFIG_COMP_PEAK_VOL" is enabled. This
change in behavior results in the following error on the firmware side:
<ERROR_MSG>
ipc: get_drv(): the provided UUID (b77e677e41885ff4a8fb14af8286bfbd)
doesn't match to any driver!
</ERROR_MSG>
for an i.MX platform using the volume component with "CONFIG_COMP_GAIN=n"
and "CONFIG_COMP_PEAK_VOL=n".
Based on the Kconfig description, "CONFIG_COMP_GAIN" refers to the gain
component, while "CONFIG_COMP_PEAK_VOL" refers to (snippet taken from the
volume Kconfig): "This option enables reporting to host peak vol regs.".
This description implies that "CONFIG_COMP_PEAK_VOL" doesn't manage the
component itself. This is further reinforced by the fact that, previously,
using the peak volume component without the "CONFIG_COMP_PEAK_VOL" config
enabled worked fine.
As such, drop all of the "CONFIG_COMP_PEAK_VOL" "ifdef" guards that were
introduced by the aforementioned commit.
Fixes fcfcb07 ("llext: remove unneeded data and functions")
Signed-off-by: Laurentiu Mihalcea laurentiu.mihalcea@nxp.com