update menu so selection is circular #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em is selected, selection goes to the fist item and going up from first item brings us to the last item)
conejoninja
reviewed
Jul 31, 2024
| if released && buttons.Pins[shifter.BUTTON_UP].Get() && selected > 0 { | ||
| selected-- | ||
| if released && buttons.Pins[shifter.BUTTON_UP].Get(){ | ||
| prevSel := selected |
There was a problem hiding this comment.
I think it's better if we pre-allocate/define the variable outside the loop (at the same time as selected instead to create it each time.
Also, maybe call it prevSelected to keep the parallelism with selected
what do you thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing with the badge, I though this could be nice as the number of menu items is growing.
Going down when the last item is selected, selection goes to the fist item
nd going up from first item brings us to the last item.