Skip to content

update menu so selection is circular #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update menu so selection is circular #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions menu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,17 @@ func menu() int16 {
for {
pressed, _ := buttons.ReadInput()

if released && buttons.Pins[shifter.BUTTON_UP].Get() && selected > 0 {
selected--
if released && buttons.Pins[shifter.BUTTON_UP].Get(){
prevSel := selected
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better if we pre-allocate/define the variable outside the loop (at the same time as selected instead to create it each time.
Also, maybe call it prevSelected to keep the parallelism with selected

what do you thing?

selected = (numOpts + selected -1) % numOpts
tinydraw.FilledCircle(&display, 32, 37+10*selected, 2, color.RGBA{200, 200, 0, 255})
tinydraw.FilledCircle(&display, 32, 37+10*(selected+1), 2, color.RGBA{255, 255, 255, 255})
tinydraw.FilledCircle(&display, 32, 37+10*prevSel, 2, color.RGBA{255, 255, 255, 255})
}
if released && buttons.Pins[shifter.BUTTON_DOWN].Get() && selected < (numOpts-1) {
selected++
if released && buttons.Pins[shifter.BUTTON_DOWN].Get() {
prevSel := selected
selected = (selected +1 ) % numOpts
tinydraw.FilledCircle(&display, 32, 37+10*selected, 2, color.RGBA{200, 200, 0, 255})
tinydraw.FilledCircle(&display, 32, 37+10*(selected-1), 2, color.RGBA{255, 255, 255, 255})
tinydraw.FilledCircle(&display, 32, 37+10*prevSel, 2, color.RGBA{255, 255, 255, 255})
}
if released && buttons.Pins[shifter.BUTTON_START].Get() {
break
Expand Down