Skip to content

Conversation

tomasjakl
Copy link
Contributor

@tomasjakl tomasjakl commented Oct 7, 2025

Description

Related Issue

Resolve #19613

🔍🖥️ Suite native android test results: View in Currents

@tomasjakl tomasjakl requested a review from a team as a code owner October 7, 2025 12:05
@tomasjakl tomasjakl added the mobile Suite Lite issues and PRs label Oct 7, 2025
@tomasjakl tomasjakl linked an issue Oct 7, 2025 that may be closed by this pull request
@tomasjakl
Copy link
Contributor Author

@coderabbitai review

Copy link

coderabbitai bot commented Oct 7, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

coderabbitai bot commented Oct 7, 2025

Walkthrough

This change updates internationalized UI messages and aligns tests. Labels switch from "Select coin" to "Select asset" across buy, sell, exchange, and general components. Fee text changes from "miners" to "validators." Approval sheet copy is revised, and some subtitles/bodies are expanded or multi-line. TradingExchangeApprovalScreen now injects providerInfo.companyName into the subtitle’s translation values alongside symbol. Corresponding test assertions are updated to match new strings. No public/exported APIs are altered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description includes the template headings and placeholder comments but lacks a meaningful summary of changes, a detailed description of what was modified and why, and entirely omits the screenshots section, leaving reviewers without the necessary context to assess the updates. Please replace the placeholder comments with a concise title summarizing the changes, add a detailed description explaining the modifications, and include screenshots demonstrating the updated UI or remove the screenshots section if it is not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely describes the primary change of updating copy in the mobile swap flow and accurately reflects the suite-native feature scope without extraneous details or noise.
Linked Issues Check ✅ Passed The changes update all relevant UI text strings in the mobile swap flow to match the final copy requirements from Figma, including button labels, descriptive subtitles, and fee text across components and tests.
Out of Scope Changes Check ✅ Passed All modifications consist of in-scope copy updates and related test adjustments for the mobile swap flow without introducing unrelated functionality or external changes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 19613-mobile-swap-update-copy-to-final

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@jbazant jbazant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbazant jbazant merged commit 205389c into develop Oct 7, 2025
22 of 23 checks passed
@jbazant jbazant deleted the 19613-mobile-swap-update-copy-to-final branch October 7, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile Swap: Update copy to final
2 participants