Allow internal nodes when isolate_as_missing #3313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3313 +/- ##
==========================================
- Coverage 89.80% 89.79% -0.01%
==========================================
Files 29 29
Lines 31043 31056 +13
Branches 5682 5685 +3
==========================================
+ Hits 27877 27888 +11
Misses 1779 1779
- Partials 1387 1389 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jeromekelleher
approved these changes
Nov 10, 2025
c/tskit/genotypes.c
Outdated
| tsk_size_t j; | ||
|
|
||
| for (j = 0; j < self->num_samples; j++) { | ||
| tsk_id_t u = self->samples[j]; |
Member
There was a problem hiding this comment.
Push declaration up to first chunk
benjeffery
force-pushed
the
internal-sample
branch
from
e73bb7b to
3f02e08
Compare
benjeffery
force-pushed
the
internal-sample
branch
from
3f02e08 to
e7e4ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to code here are relatively minor, but I went half mad thinking about if that was the right changes, so there are a lot of tests. Replaces #3301
I've split the
alignmentsfix for non-site bases into another PR that is almost done.